Fix linting issues after CI SwiftLint update (duckduckgo#2055)

Co-authored-by: Chris Brind <[email protected]>

Author: graeme

DuckDuckGo/AutofillListItemTableViewCell.swift

@@ -118,10 +118,6 @@ class AutofillListItemTableViewCell: UITableViewCell {
             contentStackView.bottomAnchor.constraint(equalTo: margins.bottomAnchor)
         ])
     }
-    
-    override func setSelected(_ selected: Bool, animated: Bool) {
-        super.setSelected(selected, animated: animated)
-    }
 
     private func setupContentView(with item: AutofillLoginListItemViewModel) {
         titleLabel.text = item.title

DuckDuckGo/DaxDialogs.swift

@@ -73,7 +73,7 @@ final class DaxDialogs {
         case .siteIsMajorTracker, .siteOwnedByMajorTracker:
             settings.browsingMajorTrackingSiteShown = flag
             settings.browsingWithoutTrackersShown = flag
-         }
+        }
     }
 
     struct BrowsingSpec: Equatable {

DuckDuckGo/KeychainItemsDebugViewController.swift

@@ -115,10 +115,6 @@ private enum SecClass: CaseIterable {
 
 class KeychainItemsDebugViewController: UITableViewController {
 
-    override func viewDidLoad() {
-        super.viewDidLoad()
-    }
-
     override func numberOfSections(in tableView: UITableView) -> Int {
         return SecClass.allCases.count
     }

DuckDuckGo/OnboardingDefaultBroswerViewController.swift

@@ -41,7 +41,4 @@ class OnboardingDefaultBroswerViewController: OnboardingContentViewController {
         super.onContinuePressed(navigationHandler: navigationHandler)
     }
 
-    override func onSkipPressed(navigationHandler: @escaping () -> Void) {
-        super.onSkipPressed(navigationHandler: navigationHandler)
-    }
 }

DuckDuckGo/SaveLoginViewController.swift

@@ -61,10 +61,6 @@ class SaveLoginViewController: UIViewController {
         viewModel?.viewControllerDidAppear()
     }
 
-    override func viewDidLayoutSubviews() {
-        super.viewDidLayoutSubviews()
-    }
-    
     override func viewDidDisappear(_ animated: Bool) {
         super.viewDidDisappear(animated)
 

DuckDuckGo/SettingsViewController.swift

@@ -544,10 +544,6 @@ class SettingsViewController: UITableViewController {
         }
     }
 
-    override func tableView(_ tableView: UITableView, titleForFooterInSection section: Int) -> String? {
-        return super.tableView(tableView, titleForFooterInSection: section)
-    }
-    
     override func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
         let rows = super.tableView(tableView, numberOfRowsInSection: section)
         if section == appearanceSectionIndex && textSizeCell.isHidden {

DuckDuckGoTests/PrivacyIconLogicTests.swift

@@ -33,14 +33,6 @@ class PrivacyIconLogicTests: XCTestCase {
     static let ddgMainURL = URL(string: "https://duckduckgo.com")!
     static let ddgSupportURL = URL(string: "https://duckduckgo.com/email/settings/support")!
 
-    override func setUp() {
-        super.setUp()
-    }
-
-    override func tearDown() {
-        super.tearDown()
-    }
-    
     func testPrivacyIconIsShieldForPageURL() {
         let url = PrivacyIconLogicTests.insecurePageURL
         let icon = PrivacyIconLogic.privacyIcon(for: url)

DuckDuckGoTests/TrackerAnimationLogicTests.swift

@@ -30,14 +30,6 @@ class TrackerAnimationLogicTests: XCTestCase {
 
     static let pageURL = URL(string: "https://example.com")!
 
-    override func setUp() {
-        super.setUp()
-    }
-
-    override func tearDown() {
-        super.tearDown()
-    }
-    
     func testAnimationLogicToAnimateTrackersIfAnyBlocked() {
         let trackerInfo = makeBlockedTrackerInfo(pageURL: Self.pageURL)
         XCTAssertTrue(TrackerAnimationLogic.shouldAnimateTrackers(for: trackerInfo))

IntegrationTests/AtbServerTests.swift

@@ -37,11 +37,7 @@ class AtbServerTests: XCTestCase {
         loader = StatisticsLoader(statisticsStore: store)
 
     }
-    
-    override func tearDown() {
-        super.tearDown()
-    }
-    
+     
     func testExtiCall() {
 
         let waitForCompletion = expectation(description: "wait for completion")