Fix nested tables and broken HTML on export #2484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A HTML export results in a table which has a stylesheet and another table nested inside. This is not valid HTML and gets auto corrected by closing the first table and opening another table. The result is the heading of the table can expand further than the remaining table. This results in a few notable changes: - The date is in a far bigger cell and it's very noticeable it's centered compared to the amounts (we may want to right align the date, though I don't have any particular thoughts about this) - We no longer have two consecutive lines with black background and the start - The table is as big as the heading (+ the default left margin)
Contributor
Author
|
Depending on what people do with the HTMLs this may also be considered breaking |
Owner
|
I'm sorry I've been slow on PRs lately; I will look at this soon. 🙏🏻 |
Owner
|
Sigh, such a fine simple PR, such a slow review. Thank you @jokesper !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A HTML export results in a table which has a stylesheet and another table nested inside. This is not valid HTML and gets auto corrected by closing the first table and opening another table. The result is the heading of the table can expand further than the remaining table.
This results in a few notable changes (as seen below):
(we may want to right align the date, though I don't have any particular thoughts about this)
Using the following small example journal:
We get the following difference:
In case we do not want this new look, I still recommend fixing the tables But in this case this can simply be done by dropping the top table and only have the heading. I do not recommend this since the table not extending as far as the heading looks (especially on a longer list of accounts) rather weird.