General Workload Launcher Cleanup (#9838)

Author: jdpgrailsdev

airbyte-workload-launcher/src/main/kotlin/pipeline/LaunchPipeline.kt

@@ -57,11 +57,10 @@ class LaunchPipeline(
         .doOnSuccess { r ->
           if (r == null) {
             metricPublisher.count(WorkloadLauncherMetricMetadata.WORKLOAD_PROCESSED_UNSUCCESSFULLY, MetricAttribute(WORKLOAD_ID_TAG, msg.workloadId))
+            logger.info { "Completed without launching workload." }
           } else {
             metricPublisher.count(WorkloadLauncherMetricMetadata.WORKLOAD_PROCESSED_SUCCESSFULLY, MetricAttribute(WORKLOAD_ID_TAG, msg.workloadId))
-          }
-          logger.info {
-            ("Success: $r")
+            logger.info { "Success: $r" }
           }
         }
         .subscribe()

airbyte-workload-launcher/src/main/resources/application.yml

@@ -5,7 +5,7 @@ micronaut:
     port: 8016
     netty:
       access-logger:
-        enabled: ${HTTP_ACCESS_LOG_ENABLED:true}
+        enabled: ${HTTP_ACCESS_LOG_ENABLED:false}
     idle-timeout: ${HTTP_IDLE_TIMEOUT:10m}
   metrics:
     enabled: true

airbyte-workload-launcher/src/test/kotlin/pipeline/LogPathTest.kt

@@ -168,7 +168,9 @@ class LogPathTest {
     assert(completeFileContent.contains("LAUNCH for workload 1"))
     if (assertException) {
       assert(completeFileContent.contains("Failure for workload 1"))
+      assert(completeFileContent.contains("Completed without launching workload."))
+    } else {
+      assert(completeFileContent.contains("Success: "))
     }
-    assert(completeFileContent.contains("Success: "))
   }
 }