Bug #33881339 Default collation causes inconsistent results

Equivalent queries would return different results, caused by slightly
different execution paths. Item::val_int_from_string() and
Item_string::val_int() should use the same algorithm for string to int
conversion.

Remove some old gis tests. They were not testing anything useful.

Change-Id: If36fc3eb79671f21a25eb9d06fa75ba1a567095e
(cherry picked from commit c1bfa079149a06229feb43eece4019886b27dc9b)

Author: Tor Didriksen

mysql-test/r/func_date_add.result

@@ -54,9 +54,9 @@ End of 5.0 tests
 #
 SELECT ADDDATE('8112-06-20', REPEAT('1', 32));
 ADDDATE('8112-06-20', REPEAT('1', 32))
-NULL
+8112-06-19
 Warnings:
-Warning	1441	Datetime function: datetime field overflow
+Warning	1292	Truncated incorrect INTEGER value: '11111111111111111111111111111111'
 # Bug#32915973: Prepare DATE_ADD/DATE_SUB incorrectly returns DATETIME
 SELECT ADDDATE(DATE'2021-01-01', INTERVAL 1 DAY);
 ADDDATE(DATE'2021-01-01', INTERVAL 1 DAY)

mysql-test/r/func_str.result

@@ -5661,3 +5661,16 @@ NULL
 DROP TABLE t1;
 CREATE TABLE t1 AS SELECT HEX(-1) AS f;
 DROP TABLE t1;
+#
+# Bug #33881339 Default collation causes inconsistent results
+#
+CREATE TABLE t0(c0 DECIMAL);
+INSERT INTO t0 VALUES(NULL);
+UPDATE t0 SET c0 = 1 WHERE (t0.c0 IS NULL)>>('');
+ERROR 22007: Truncated incorrect INTEGER value: ''
+DROP TABLE t0;
+CREATE TABLE t0(c0 DECIMAL);
+INSERT INTO t0 VALUES(NULL);
+UPDATE t0 SET c0 = 1 WHERE (t0.c0 IS NULL)>>('' COLLATE 'utf8mb4_0900_ai_ci');
+ERROR 22007: Truncated incorrect INTEGER value: ''
+DROP TABLE t0;

mysql-test/r/gis-rtree.result

@@ -17719,7 +17719,7 @@ DROP TABLE t1;
 #
 do date_add(utc_time(), interval(oct(-11779)) microsecond);
 Warnings:
-Warning	1441	Datetime function: time field overflow
+Warning	1292	Truncated incorrect INTEGER value: '1777777777777777750775'
 #
 # Bug #31054071 UBSAN: SIGNED INTEGER OVERFLOW IN
 #               ITEM_DATE_ADD_INTERVAL::GET_TIME_INTERNAL

mysql-test/r/type_temporal_fractional.result

@@ -453,6 +453,8 @@ Catalog	Database	Table	Table_alias	Column	Column_alias	Type	Length	Max length	Is
 def					CAST(0x01 AS char) | 0x31393838	8	21	9	Y	32928	0	63
 CAST(0x01 AS char) | 0x31393838
 825833528
+Warnings:
+Warning	1292	Truncated incorrect INTEGER value: '
'
 SELECT 0x01 << 1;
 Catalog	Database	Table	Table_alias	Column	Column_alias	Type	Length	Max length	Is_null	Flags	Decimals	Charsetnr
 def					0x01 << 1	8	21	1	N	32929	0	63

mysql-test/r/varbinary.result

@@ -1190,6 +1190,8 @@ Warnings:
 Warning	3719	'utf8' is currently an alias for the character set UTF8MB3, but will be an alias for UTF8MB4 in a future release. Please consider using UTF8MB4 in order to be unambiguous.
 do weight_string(extractvalue('','/*/a'));
 do char((weight_string(extractvalue((''),('tX')))) using cp852);
+Warnings:
+Warning	1292	Truncated incorrect INTEGER value: ''
 set names default;
 #
 # Bug#22552615 EXTRACTVALUE RETURNS NULL WHEN NO MATCHING