Skip to content

Commit 5745bb3

Browse files
Disable click listener detection and bump to v1.63.3.
1 parent 2983802 commit 5745bb3

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,8 @@ In `master` (not yet released)
185185
- Fix [#2958](https://github.com/philc/vimium/issues/2958#issuecomment-366488659), link hints broken for `target="_blank"` links.
186186
- 1.63.2 (Firefox only):
187187
- Fix [#2962](https://github.com/philc/vimium/issues/2962), find mode broken on Firefox Quantum.
188+
- 1.63.3:
189+
- Fix [#2997](https://github.com/philc/vimium/issues/2997), Vimium's DOM injection breaks Google Pay site.
188190

189191
1.62 (2017-12-09)
190192

content_scripts/injected.coffee

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
# NOTE(smblott) Disabled pending resolution of #2997.
2+
return
3+
14
# The code in `injectedCode()`, below, is injected into the page's own execution context.
25
#
36
# This is based on method 2b here: http://stackoverflow.com/a/9517879, and

content_scripts/link_hints.coffee

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -706,8 +706,9 @@ LocalHints =
706706
isClickable = true
707707
reason = "Open."
708708

709-
# Detect elements with "click" listeners installed with `addEventListener()`.
710-
isClickable ||= element.hasAttribute "_vimium-has-onclick-listener"
709+
# NOTE(smblott) Disabled pending resolution of #2997.
710+
# # Detect elements with "click" listeners installed with `addEventListener()`.
711+
# isClickable ||= element.hasAttribute "_vimium-has-onclick-listener"
711712

712713
# An element with a class name containing the text "button" might be clickable. However, real clickables
713714
# are often wrapped in elements with such class names. So, when we find clickables based only on their

manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"manifest_version": 2,
33
"name": "Vimium",
4-
"version": "1.63.2",
4+
"version": "1.63.3",
55
"description": "The Hacker's Browser. Vimium provides keyboard shortcuts for navigation and control in the spirit of Vim.",
66
"icons": { "16": "icons/icon16.png",
77
"48": "icons/icon48.png",

0 commit comments

Comments
 (0)