Skip to content

Commit 60ba379

Browse files
maybe-sybrauvipy
authored andcommitted
fix: node_format() logfile before detaching
Fixes celery#6426
1 parent 28ebcce commit 60ba379

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

celery/bin/worker.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,11 @@ def detach(path, argv, logfile=None, pidfile=None, uid=None,
9494
executable=None, hostname=None):
9595
"""Detach program by argv."""
9696
fake = 1 if C_FAKEFORK else fake
97+
# `detached()` will attempt to touch the logfile to confirm that error
98+
# messages won't be lost after detaching stdout/err, but this means we need
99+
# to pre-format it rather than relying on `setup_logging_subsystem()` like
100+
# we can elsewhere.
101+
logfile = node_format(logfile, hostname)
97102
with detached(logfile, pidfile, uid, gid, umask, workdir, fake,
98103
after_forkers=False):
99104
try:

0 commit comments

Comments
 (0)