Move proxy fix to cubejs-backend-shared instead and use that

Author: johnsca

packages/cubejs-api-gateway/package.json

@@ -45,7 +45,6 @@
     "moment-timezone": "^0.5.27",
     "nexus": "^1.1.0",
     "node-fetch": "^2.6.1",
-    "proxy-agent": "^6.4.0",
     "ramda": "^0.27.0",
     "uuid": "^8.3.2"
   },

packages/cubejs-api-gateway/src/jwk.ts

@@ -1,9 +1,8 @@
 /* eslint-disable no-restricted-syntax */
 import crypto from 'crypto';
-import { asyncMemoizeBackground, asyncRetry, BackgroundMemoizeOptions } from '@cubejs-backend/shared';
+import { asyncMemoizeBackground, asyncRetry, BackgroundMemoizeOptions, getHttpAgentForProxySettings } from '@cubejs-backend/shared';
 import fetch from 'node-fetch';
 import jwkToPem from 'jwk-to-pem';
-import { ProxyAgent } from 'proxy-agent';
 import { JWTOptions } from './interfaces';
 
 const HEADER_REGEXP = /([a-zA-Z][a-zA-Z_-]*)\s*(?:=(?:"([^"]*)"|([^ \t",;]*)))?/g;
@@ -52,7 +51,7 @@ export type JWKsFetcherOptions = Pick<BackgroundMemoizeOptions<any, any>, 'onBac
 
 export const createJWKsFetcher = (jwtOptions: JWTOptions, options: JWKsFetcherOptions) => {
   const fetchJwkUrl = asyncMemoizeBackground(async (url: string) => {
-    const response = await asyncRetry(() => fetch(url, { agent: new ProxyAgent() }), {
+    const response = await asyncRetry(() => fetch(url, { agent: await getHttpAgentForProxySettings() }), {
       times: jwtOptions.jwkRetry || 3,
     });
     const json = await response.json();

packages/cubejs-backend-shared/package.json

@@ -42,7 +42,7 @@
     "decompress": "^4.2.1",
     "env-var": "^6.3.0",
     "fs-extra": "^9.1.0",
-    "http-proxy-agent": "^4.0.1",
+    "proxy-agent": "^6.4.0",
     "moment-range": "^4.0.1",
     "moment-timezone": "^0.5.33",
     "node-fetch": "^2.6.1",

packages/cubejs-backend-shared/src/proxy.ts

@@ -1,5 +1,5 @@
 import { exec } from 'child_process';
-import HttpsProxyAgent from 'http-proxy-agent';
+import { ProxyAgent } from 'proxy-agent';
 
 function getCommandOutput(command: string) {
   return new Promise<string>((resolve, reject) => {
@@ -14,6 +14,7 @@ function getCommandOutput(command: string) {
   });
 }
 
+// deprecated, use ProxyAgent instead
 export async function getProxySettings() {
   const [proxy] = (
     await Promise.all([getCommandOutput('npm config -g get https-proxy'), getCommandOutput('npm config -g get proxy')])
@@ -25,7 +26,5 @@ export async function getProxySettings() {
 }
 
 export async function getHttpAgentForProxySettings() {
-  const proxy = await getProxySettings();
-
-  return proxy ? HttpsProxyAgent(proxy) : undefined;
+  return new ProxyAgent();
 }