lint and justfile target

Author: kapilt

justfile

@@ -0,0 +1,7 @@
+
+
+lint:
+  pre-commit run --all-files
+
+test:
+  pytest -v tests/unit

tests/unit/conftest.py

@@ -4,47 +4,43 @@
 import boto3
 import jsonschema
 import pytest
-import logging
 
 
 @pytest.fixture()
 def validator():
-
     def schema_validate(translator, resource):
-        schema_path = f'schema.{translator.tf_type}.json'
+        schema_path = f"schema.{translator.tf_type}.json"
         schema = load_data(schema_path)
         if schema is None:
-            cfn = boto3.client('cloudformation')
-            rtype = cfn.describe_type(
-                TypeName=translator.cfn_type, Type='RESOURCE')
-            schema = json.loads(rtype['Schema'])
-            (Path(__file__).parent / "data" / schema_path).write_text(json.dumps(schema, indent=2))
+            cfn = boto3.client("cloudformation")
+            rtype = cfn.describe_type(TypeName=translator.cfn_type, Type="RESOURCE")
+            schema = json.loads(rtype["Schema"])
+            (Path(__file__).parent / "data" / schema_path).write_text(
+                json.dumps(schema, indent=2)
+            )
 
         props = set(resource)
         sprops = set(schema["properties"].keys())
         unknown = props.difference(sprops)
         if unknown:
-            raise KeyError("unknown resource keys %s" % (', '.join(unknown)))
+            raise KeyError("unknown resource keys %s" % (", ".join(unknown)))
 
         validator = jsonschema.Draft7Validator(schema)
-    
+
         errors = list(validator.iter_errors(resource))
         if errors:
-            print(
-                "%s errors %d" % (translator.cfn_type, len(errors))
-            )
+            print("%s errors %d" % (translator.cfn_type, len(errors)))
 
         for e in errors:
-            print("Resource %s error:\n %s" % (translator.cfn_type, str(e)))        
+            print("Resource %s error:\n %s" % (translator.cfn_type, str(e)))
 
         if errors:
             raise ValueError(
-                f"resource type {translator.cfn_type} had translation errors")
+                f"resource type {translator.cfn_type} had translation errors"
+            )
 
     return schema_validate
 
-            
-    
 
 def load_data(filename):
     path = Path(__file__).parent / "data" / filename

tests/unit/test_resources.py

@@ -1,13 +1,10 @@
-
 from conftest import load_data
 from tfdevops.cli import Translator
 
 
 def test_elasticache_replication_group(validator):
 
-    translator = Translator.get_translator('elasticache_replication_group')()
-    resource = load_data('elasticache.json')
+    translator = Translator.get_translator("elasticache_replication_group")()
+    resource = load_data("elasticache.json")
     props = translator.get_properties(resource)
     validator(translator, props)
-
-    

tfdevops/cli.py

@@ -377,8 +377,7 @@ def validate(template):
     help="S3 Bucket and Prefix (s3://bucket/pre/fix) for oversized templates and resources",
 )
 @click.option(
-    "--state-file",
-    help="Terraform state file - output of terraform show -json",
+    "--state-file", help="Terraform state file - output of terraform show -json",
 )
 @click.option("--types", multiple=True, help="Only consider these terraform types")
 def cfn(module, template, resources, types, s3_path, state_file):