Welcome to CS336 Discussions!

[marcelroed]

👋 Welcome!

We’re using Discussions as a place to connect with other members of our community. We hope that you:

• Ask questions you’re wondering about.
• Share ideas.
• Engage with other community members.
• Welcome others and are open-minded.

[MouseAndKeyboard]

thanks bro ! 💪 keep up the good work

[bchoor]

@marcelroed when writing code, the instructions are to write it in the *_basics folder. do we need to make updates to the adapters file in test to reference code in *_basics? Or are we writing our code directly in the adapters file?

is there a minimal example of the adapters file, maybe with the first one get_tokenizer? Even if it's just showing the structure of the folder

• cs336_basics/
  --- get_tokenizer.py

• tests/
  --- adapters.py (from ../cs336_basics/get_tokenizer.py import get_tokenizer)

is it sort of what's expected here?

side note, first time taking such a class online.

[vskogstad]

Hi,

I'm not affiliated with the course, so take this with a grain of salt.
I did it the same way that you propose at first. I make a minimal update to adapters.py to load in my function/class from cs336_basics. I have the files structured the same way as you propose above and within each function of adapters.py you basically have two lines, importing and returing. Example adapter for get_tokenizer (i have a python-file named tokenizer.py in cs336_basics):

from cs336_basics.tokenizer import Tokenizer
return Tokenizer(vocab=vocab, merges=merges, special_tokens=special_tokens)

[marcelroed]

Hi! Sorry for the late reply! We expect that you structure your code however you want in cs336_basics, then edit adapters.py to use your code. What @vskogstad indicated is correct!