-
Notifications
You must be signed in to change notification settings - Fork 163
refactor: Analysis cleanup #2032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adriano-stacks
merged 12 commits into
stx-labs:main
from
jbencin-stacks:refactor/analysis-cleanup
Nov 6, 2025
Merged
refactor: Analysis cleanup #2032
adriano-stacks
merged 12 commits into
stx-labs:main
from
jbencin-stacks:refactor/analysis-cleanup
Nov 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
7aa7efe to
5f2fd37
Compare
3cc8bca to
e97fe61
Compare
brady-stacks
approved these changes
Nov 6, 2025
Contributor
brady-stacks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a
lintssection of the config, and alintsdirectory in which to place new lints. This will help the linter scale and make it easier to add and manage lints.Initially I was going to remove the
passessection of the config, and move existing analysis passes tolints, but decided to keep it so that this PR can be merged without affecting existing users. I'm only moving thenooplint right now, which is new anyways.I expect the
lintssection of the config will continue to evolve as I work on it, and should be considered unstable. Once it stabilizes, I'm going to renamecall_checkerandcheck_checkerand move them underlintsBreaking change?
Only if currently user has
noop_checkerenabled in their config fileExample
Lints can be enabled/disabled by assigning a lint level to the lint name, which can be one of the following:
ignorenoticewarningerrorThere are several aliases allowed for the warning levels. For example,
allow,off, andfalseare all valid aliases forignore