Skip to content

Conversation

@jbencin-stacks
Copy link
Collaborator

@jbencin-stacks jbencin-stacks commented Oct 24, 2025

Description

Create a lints section of the config, and a lints directory in which to place new lints. This will help the linter scale and make it easier to add and manage lints.

Initially I was going to remove the passes section of the config, and move existing analysis passes to lints, but decided to keep it so that this PR can be merged without affecting existing users. I'm only moving the noop lint right now, which is new anyways.

I expect the lints section of the config will continue to evolve as I work on it, and should be considered unstable. Once it stabilizes, I'm going to rename call_checker and check_checker and move them under lints

Breaking change?

Only if currently user has noop_checker enabled in their config file

Example

Lints can be enabled/disabled by assigning a lint level to the lint name, which can be one of the following:

  • ignore
  • notice
  • warning
  • error

There are several aliases allowed for the warning levels. For example, allow, off, and false are all valid aliases for ignore

[repl.analysis.lints]
noop = "error"
unused_var = "allow"
unused_const = "warn"
unused_map = "off"

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 78.02198% with 20 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
components/clarity-repl/src/analysis/mod.rs 63.63% 20 Missing ⚠️

📢 Thoughts on this report? Let us know!

@jbencin-stacks jbencin-stacks marked this pull request as draft October 27, 2025 14:03
@jbencin-stacks jbencin-stacks force-pushed the refactor/analysis-cleanup branch from 7aa7efe to 5f2fd37 Compare November 6, 2025 16:05
@jbencin-stacks jbencin-stacks marked this pull request as ready for review November 6, 2025 16:42
@jbencin-stacks jbencin-stacks force-pushed the refactor/analysis-cleanup branch from 3cc8bca to e97fe61 Compare November 6, 2025 16:53
Copy link
Contributor

@brady-stacks brady-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

@adriano-stacks adriano-stacks merged commit f9cb680 into stx-labs:main Nov 6, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants