Skip to content

Commit 90bf58a

Browse files
authored
fix typo (oceanbase#54)
1 parent 38ca7f7 commit 90bf58a

File tree

11 files changed

+43
-44
lines changed

11 files changed

+43
-44
lines changed

deps/oblib/src/lib/ob_define.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ const int64_t OB_MAX_TRANS_ID_BUFFER_SIZE = 512;
288288
const int32_t OB_MIN_SAFE_COPY_COUNT = 3;
289289
const int32_t OB_SAFE_COPY_COUNT = 3;
290290
const int32_t OB_DEFAULT_REPLICA_NUM = 3;
291-
const int32_t OB_DEC_AND_LOCK = 2626; /* used by remoe_plan in ObPsStore */
291+
const int32_t OB_DEC_AND_LOCK = 2626; /* used by remote_plan in ObPsStore */
292292
const int32_t OB_MAX_SCHEMA_VERSION_INTERVAL = 40 * 1000 * 1000; // 40s
293293
const int64_t UPDATE_SCHEMA_ADDITIONAL_INTERVAL = 5 * 1000 * 1000L; // 5s
294294

@@ -834,7 +834,7 @@ const uint64_t OB_GTS_UNIT_ID = 100;
834834
const int64_t OB_GTS_QUORUM = 3;
835835
const char* const OB_ORIGINAL_GTS_NAME = "primary_gts_instance";
836836
const uint64_t OB_ORIGINAL_GTS_ID = 100;
837-
// standby unit config tmplate
837+
// standby unit config template
838838
const char* const OB_STANDBY_UNIT_CONFIG_TEMPLATE_NAME = "standby_unit_config_template";
839839

840840
const uint64_t OB_SCHEMATA_TID = 2001;
@@ -1494,7 +1494,7 @@ const int64_t OB_MAX_CPU_NUM = 128;
14941494
const int64_t OB_MAX_STATICS_PER_TABLE = 128;
14951495

14961496
const uint64_t OB_DEFAULT_INDEX_ATTRIBUTES_SET = 0;
1497-
const uint64_t OB_DEFAULT_INDEX_VISIBILITY = 0; // 0 menas visible;1 means invisible
1497+
const uint64_t OB_DEFAULT_INDEX_VISIBILITY = 0; // 0 means visible;1 means invisible
14981498

14991499
const int64_t OB_INDEX_WRITE_START_DELAY = 20 * 1000 * 1000; // 20s
15001500

deps/oblib/src/lib/ob_name_def.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@
228228
#define N_ROWKEY_LIST "rowkey_list"
229229
#define N_READ_MASTER "read_master"
230230
#define N_RESULT_CACHED "result_cached"
231-
#define N_NOT_EXIST_COL_RET_NOP "not_exsit_col_ret_as_nop"
231+
#define N_NOT_EXIST_COL_RET_NOP "not_exist_col_ret_as_nop"
232232
#define N_RAW_EXPR "raw_expr"
233233
#define N_ROWKEY_CELL_NUM "rowkey_cell_num"
234234
#define N_CELL "cell"

deps/oblib/src/lib/ob_name_id_def.h

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ DEF_NAME(revert_scan_iter, "revert scan iterator")
149149
DEF_NAME(get_row, "get row")
150150
DEF_NAME(plc_sys_cache_get, "plc sys cache get end")
151151
DEF_NAME(plc_user_cache_get_end, "plc user cache get end")
152-
DEF_NAME(tl_calc_parid_end, "tl calc part id end")
152+
DEF_NAME(tl_calc_partid_end, "tl calc part id end")
153153
DEF_NAME(tl_calc_by_range_end, "tl calc by range end")
154154
DEF_NAME(pc_fast_parse_start, "pc fast parse start")
155155
DEF_NAME(pc_fast_parse_end, "pc fast parse end")
@@ -326,9 +326,9 @@ DEF_NAME(send_devote_vote, "send devote vote")
326326
DEF_NAME(send_vote_vote, "send vote vote")
327327
DEF_NAME(send_devote_success, "send devote success")
328328
DEF_NAME(send_vote_success, "send vote success")
329-
DEF_NAME(try_centrialized_voting, "try centrialized voting")
330-
DEF_NAME(check_decentrialized_majority, "check decentrialized majority")
331-
DEF_NAME(check_centrialized_majority, "check centrialized majority")
329+
DEF_NAME(try_centralized_voting, "try centralized voting")
330+
DEF_NAME(check_decentralized_majority, "check decentralized majority")
331+
DEF_NAME(check_centralized_majority, "check centralized majority")
332332
DEF_NAME(upgrade_mode, "upgrade mode")
333333
DEF_NAME(run_gt1_task, "run gt1 task")
334334
DEF_NAME(response_scheduler, "response scheduler")
@@ -411,7 +411,7 @@ DEF_NAME(max_log_ack_list, "max log ack list")
411411
DEF_NAME(replay_start_working_log, "replay start working log")
412412
// perf event
413413
DEF_NAME(S_scan_iter, "storage: scan iterator")
414-
DEF_NAME(pc_fast_gen_stmt_key_end, "plan cache: fast genarate stmt_key")
414+
DEF_NAME(pc_fast_gen_stmt_key_end, "plan cache: fast generate stmt_key")
415415
DEF_NAME(pc_plan_cache_hit, "plan cache: init")
416416
DEF_NAME(FROM_resolved, "resolver: from clause")
417417
DEF_NAME(SELECT_resolved, "resolver: select clause")
@@ -478,11 +478,10 @@ DEF_NAME(revert_insert_iter, "revert_insert_iter")
478478
DEF_NAME(revert_insert_iter_end, "revert_insert_iter_end")
479479
DEF_NAME(revert_scan_iter_end, "revert_scan_iter_end")
480480
DEF_NAME(replace_end, "replace_end")
481-
DEF_NAME(repalce_start_insert, "repalce_start_insert")
481+
DEF_NAME(replace_start_insert, "replace_start_insert")
482482
DEF_NAME(replace_end_insert, "replace_end_insert")
483483
DEF_NAME(replace_start_delete, "replace_start_delete")
484484
DEF_NAME(replace_end_delete, "replace_end_delete")
485-
DEF_NAME(replace_start_insert, "replace_start_insert")
486485
DEF_NAME(replace_start_scan_row, "replace_start_scan_row")
487486
DEF_NAME(replace_start_table_scan, "replace_start_table_scan")
488487
DEF_NAME(replace_end_table_scan, "replace_end_table_scan")

deps/oblib/src/lib/oblog/ob_log.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2059,7 +2059,7 @@ int64_t ObLogger::get_wait_us(const int32_t level)
20592059
default: {
20602060
ret_timeout_us = 0; // 0us
20612061
break;
2062-
// do nothiong
2062+
// do nothing
20632063
}
20642064
}
20652065
}

deps/oblib/src/lib/oblog/ob_log.h

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ class ObPLogItem;
214214
}
215215

216216
//@class ObLogIdLevelMap
217-
//@brief stroe the level of each par-module and sub-module. The key is module ID.
217+
//@brief store the level of each par-module and sub-module. The key is module ID.
218218
// To be used for SQL hint, this class should be POD-type.
219219
struct ObLogIdLevelMap {
220220
static const uint64_t MAX_PAR_MOD_SIZE = OB_LOG_MAX_PAR_MOD_SIZE;
@@ -759,8 +759,8 @@ class ObLogger : public ObBaseLogWriter {
759759
//@param[in] flag Whether redirect the stdout and stderr to the descriptor of the log-file.
760760
// FALSE:redirect TRUE:no redirect.
761761
//@param[in] open_wf whether create warning log-file to store warning buffer.
762-
//@param[in] finename of rootservice log-file's name.
763-
//@param[in] finename of election log-file's name.
762+
//@param[in] filename of rootservice log-file's name.
763+
//@param[in] filename of election log-file's name.
764764
void set_file_name(const char* filename, const bool no_redirect_flag = false, const bool open_wf = false,
765765
const char* rs_filename = NULL, const char* elec_filename = NULL);
766766

@@ -937,10 +937,10 @@ class ObLogger : public ObBaseLogWriter {
937937
//@brief Rename the log to a filename with fmt. And open a new file with the old, then add old file to file_list.
938938
//@param[in] filename the old filename to rotate.
939939
//@param[in] whether redirect, FALSE:redirect TRUE:no redirect
940-
//@param[out] after retated log, open new file_fd
941-
//@param[out] after retated wf log, open new wf_file_fd
942-
//@param[out] add retated log file name to file list
943-
//@param[out] add retated wf log file name to file list
940+
//@param[out] after rotated log, open new file_fd
941+
//@param[out] after rotated wf log, open new wf_file_fd
942+
//@param[out] add rotated log file name to file list
943+
//@param[out] add rotated wf log file name to file list
944944
void rotate_log(const char* filename, const ObPLogFDType fd_type, const bool redirect_flag, int32_t& fd,
945945
int32_t& wf_fd, std::deque<std::string>& file_list, std::deque<std::string>& wf_file_list);
946946

@@ -966,7 +966,7 @@ class ObLogger : public ObBaseLogWriter {
966966

967967
private:
968968
static const char* const errstr_[];
969-
// default log rate limiter if there's no tl_log_limiger
969+
// default log rate limiter if there's no tl_log_limiter
970970
static ::oceanbase::lib::ObRateLimiter* default_log_limiter_;
971971
static RLOCAL(lib::ObRateLimiter*, tl_log_limiter_);
972972
static constexpr int N_LIMITER = 4096;
@@ -1004,8 +1004,8 @@ class ObLogger : public ObBaseLogWriter {
10041004
bool force_check_; // whether check log-file at each message logging.
10051005
bool redirect_flag_; // whether redirect, TRUE: redirect FALSE: no redirect.
10061006
bool open_wf_flag_; // whether open warning log-file.
1007-
bool enable_wf_flag_; // whether write waring log to wf log-file.
1008-
bool rec_old_file_flag_; // whether recorde old file.
1007+
bool enable_wf_flag_; // whether write warning log to wf log-file.
1008+
bool rec_old_file_flag_; // whether record old file.
10091009
volatile bool can_print_; // when disk has no space, logger control
10101010

10111011
bool enable_async_log_; // if false, use sync way logging

src/election/ob_election.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -758,8 +758,8 @@ int ObElection::process_vote_prepare_(const ObElectionMsgPrepare& msg)
758758
ELECT_ASYNC_LOG_(WARN, "store prepare message error", K(ret), K(*this), K(msg));
759759
} else {
760760
// T1_timestamp_ = msg.get_T1_timestamp();
761-
if (OB_FAIL(try_centrialized_voting_(now_lease_time, msg.get_T1_timestamp()))) {
762-
ELECT_ASYNC_LOG_(WARN, "try centrialized voting error", K(ret), K(*this), K(msg), K(now_lease_time));
761+
if (OB_FAIL(try_centralized_voting_(now_lease_time, msg.get_T1_timestamp()))) {
762+
ELECT_ASYNC_LOG_(WARN, "try centralized voting error", K(ret), K(*this), K(msg), K(now_lease_time));
763763
}
764764
}
765765
}
@@ -895,8 +895,8 @@ int ObElection::process_vote_vote_(const ObElectionMsgVote& msg)
895895
ELECT_ASYNC_LOG_(WARN, "collect_valid_candidates error", K(ret), K_(partition), K(msg));
896896
} else if (OB_FAIL(msg_pool_.store(msg))) {
897897
ELECT_ASYNC_LOG_(WARN, "store vote message error", K(ret), K(*this), K(msg));
898-
} else if (OB_FAIL(check_centrialized_majority_())) {
899-
ELECT_ASYNC_LOG_(WARN, "check_centrialized_majority error", K(ret), K(*this), K(msg));
898+
} else if (OB_FAIL(check_centralized_majority_())) {
899+
ELECT_ASYNC_LOG_(WARN, "check_centralized_majority error", K(ret), K(*this), K(msg));
900900
} else {
901901
// do nothing
902902
}
@@ -3186,7 +3186,7 @@ int ObElection::send_devote_vote_(const ObAddr& server, const ObElectionMsgDEVot
31863186
return ret;
31873187
}
31883188

3189-
int ObElection::try_centrialized_voting_(const int64_t lease_time, int64_t msg_t1)
3189+
int ObElection::try_centralized_voting_(const int64_t lease_time, int64_t msg_t1)
31903190
{
31913191
int ret = OB_SUCCESS;
31923192
ObAddr msg_cur_leader;
@@ -3255,7 +3255,7 @@ int ObElection::try_centrialized_voting_(const int64_t lease_time, int64_t msg_t
32553255
// if self is in reappointing, need majority's message
32563256
// if self is in changing leader, need majority's message and new leader's message
32573257
// 2.if there are enough messages, send vote success message
3258-
int ObElection::check_centrialized_majority_()
3258+
int ObElection::check_centralized_majority_()
32593259
{
32603260
int ret = OB_SUCCESS;
32613261
ObAddr cur_leader;

src/election/ob_election.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -286,8 +286,8 @@ class ObElection : public ObIElection, public ObIElectionTimerP, public ObElecti
286286
bool change_leader_time_out_of_range_(const int64_t cur_ts, const int64_t expect_ts) const;
287287
int get_decentralized_candidate_(common::ObAddr& server, ObElectionPriority& priority, int64_t& lease_time);
288288
int get_centralized_candidate_(common::ObAddr& cur_leader, common::ObAddr& new_leader, int64_t msg_t1);
289-
int try_centrialized_voting_(const int64_t lease_time, int64_t msg_t1);
290-
int check_centrialized_majority_();
289+
int try_centralized_voting_(const int64_t lease_time, int64_t msg_t1);
290+
int check_centralized_majority_();
291291
int check_decentralized_majority_(common::ObAddr& new_leader, int64_t& ticket);
292292
int collect_valid_candidates_(const ObElectionMsgVote& msg);
293293
int send_devote_prepare_(const ObElectionMsgDEPrepare& msg);

src/election/ob_election_group.cpp

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -807,15 +807,15 @@ int ObElectionGroup::process_vote_prepare_(const ObElectionMsgEGPrepare& msg, co
807807
ELECT_ASYNC_LOG_(WARN, "store prepare message error", K(ret), "election_group", *this, K(msg));
808808
} else {
809809
T1_timestamp_ = msg_t1;
810-
if (OB_FAIL(try_centrialized_voting_(now_lease_time))) {
811-
ELECT_ASYNC_LOG_(WARN, "try centrialized voting error", K(ret), "self", *this, K(msg), K(now_lease_time));
810+
if (OB_FAIL(try_centralized_voting_(now_lease_time))) {
811+
ELECT_ASYNC_LOG_(WARN, "try centralized voting error", K(ret), "self", *this, K(msg), K(now_lease_time));
812812
} else {
813813
if (msg_eg_version != eg_version_ && ROLE_SLAVE == role_) {
814814
ELECT_ASYNC_LOG_(
815815
INFO, "eg_version not equal with leader when send_vote_vote", K(msg), K(msg_eg_version), "self", *this);
816816
}
817817
}
818-
REC_TRACE_EXT(tlog_, try_centrialized_voting, Y(ret), Y_(vote_period), Y(lease_time));
818+
REC_TRACE_EXT(tlog_, try_centralized_voting, Y(ret), Y_(vote_period), Y(lease_time));
819819
}
820820
}
821821
}
@@ -896,7 +896,7 @@ int ObElectionGroup::handle_vote_prepare(
896896
return ret;
897897
}
898898

899-
int ObElectionGroup::try_centrialized_voting_(const int64_t lease_time)
899+
int ObElectionGroup::try_centralized_voting_(const int64_t lease_time)
900900
{
901901
int ret = OB_SUCCESS;
902902
ObAddr msg_cur_leader;
@@ -1162,7 +1162,7 @@ void ObElectionGroup::clear_part_stat_vote_cnt_()
11621162
// receive new message
11631163
// 1. check if received enough messages
11641164
// 2. if so, send vote success message
1165-
int ObElectionGroup::check_centrialized_majority_()
1165+
int ObElectionGroup::check_centralized_majority_()
11661166
{
11671167
int ret = OB_SUCCESS;
11681168
ObAddr cur_leader;
@@ -1184,7 +1184,7 @@ int ObElectionGroup::check_centrialized_majority_()
11841184
if (OB_ELECTION_WARN_NOT_REACH_MAJORITY == ret || OB_ELECTION_WAIT_LEADER_MESSAGE == ret) {
11851185
// no enough message or waiting for leader's message
11861186
} else {
1187-
ELECT_ASYNC_LOG_(WARN, "check_centrialized_majority_ error", K(ret), K_(eg_id));
1187+
ELECT_ASYNC_LOG_(WARN, "check_centralized_majority_ error", K(ret), K_(eg_id));
11881188
}
11891189
} else {
11901190
bool arg_all_part_merged_in = is_all_part_merged_in_;
@@ -1229,7 +1229,7 @@ int ObElectionGroup::check_centrialized_majority_()
12291229
}
12301230
} else {
12311231
ret = OB_STATE_NOT_MATCH;
1232-
FORCE_ELECT_LOG(WARN, "check_centrialized_majority_ error", K(ret), K(*this), K(cur_leader));
1232+
FORCE_ELECT_LOG(WARN, "check_centralized_majority_ error", K(ret), K(*this), K(cur_leader));
12331233
}
12341234
}
12351235
clear_part_stat_vote_cnt_();
@@ -1957,10 +1957,10 @@ void ObElectionGroup::run_gt3_task(const int64_t expect_ts)
19571957
ELECT_ASYNC_LIMIT_LOG(
19581958
WARN, "run time out of range", K(ret), "self", *this, K(cur_ts), K(expect_ts), "delta", cur_ts - expect_ts);
19591959
} else {
1960-
if (OB_FAIL(check_centrialized_majority_())) {
1961-
ELECT_ASYNC_LOG_(WARN, "check_centrialized_majority_ error", K(ret), "self", *this);
1960+
if (OB_FAIL(check_centralized_majority_())) {
1961+
ELECT_ASYNC_LOG_(WARN, "check_centralized_majority_ error", K(ret), "self", *this);
19621962
}
1963-
REC_TRACE_EXT(tlog_, check_centrialized_majority, Y(ret));
1963+
REC_TRACE_EXT(tlog_, check_centralized_majority, Y(ret));
19641964
}
19651965
ELECT_ASYNC_LOG(DEBUG, "GT3Task", K(ret), "self", *this, K(expect_ts), K(cur_ts));
19661966
}

src/election/ob_election_group.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -264,8 +264,8 @@ class ObElectionGroup : public ObIElectionGroup, public ObIElectionTimerP {
264264
bool run_time_out_of_range_(const int64_t cur_ts, const int64_t expect_ts) const;
265265
bool vote_run_time_out_of_range_(const int64_t cur_ts, const int64_t expect_ts) const;
266266
int get_eg_centralized_candidate_(common::ObAddr& cur_leader, common::ObAddr& new_leader);
267-
int try_centrialized_voting_(const int64_t lease_time);
268-
int check_centrialized_majority_();
267+
int try_centralized_voting_(const int64_t lease_time);
268+
int check_centralized_majority_();
269269
void set_unconfirmed_leader_(const common::ObAddr& unconfirmed_leader);
270270
int set_unconfirmed_leader_lease_(const int64_t start, const int64_t end);
271271
bool unconfirmed_leader_lease_is_expired_(const int64_t cur_ts) const;

src/sql/engine/dml/ob_table_replace.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@ int ObTableReplace::try_insert(ObExecContext& ctx, ObExprCtx& expr_ctx, const Ob
413413
}
414414
SQL_ENG_LOG(DEBUG, "calc row for insert:", K(ret), K(replace_ctx->insert_row_));
415415
replace_ctx->record_++;
416-
NG_TRACE_TIMES(2, repalce_start_insert);
416+
NG_TRACE_TIMES(2, replace_start_insert);
417417
if (OB_SUCC(partition_service->insert_row(my_session->get_trans_desc(),
418418
dml_param,
419419
part_key,

0 commit comments

Comments
 (0)