#7225 Converting a Text question to the Email question type doesn't enable the "inputType": "email" option (#7227)

Fixes #7225

Author: novikov82

packages/survey-creator-core/src/creator-base.ts

@@ -4425,11 +4425,11 @@ export class SurveyCreatorModel extends Base
       iconSize: "auto",
       visible: item.visible,
       enabled: item.enabled,
-      needSeparator: needSeparator
+      needSeparator: needSeparator,
+      action: () => {
+        onSelectQuestionType(item.typeName, item.json);
+      }
     });
-    action.action = () => {
-      onSelectQuestionType(item.typeName, item.json);
-    };
 
     if (!!item.items && item.items.length > 0 && this.toolbox.showSubitems) {
       const innerItems = item.items.map(i => new Action({

packages/survey-creator-core/tests/question-adorner.tests.ts

@@ -1,5 +1,5 @@
 import { QuestionAdornerViewModel } from "../src/components/question";
-import { Action, ComponentCollection, PopupDropdownViewModel, QuestionPanelDynamicModel, QuestionRadiogroupModel, settings, SurveyElement, SurveyModel, settings as surveySettings } from "survey-core";
+import { Action, ComponentCollection, PopupDropdownViewModel, QuestionPanelDynamicModel, QuestionRadiogroupModel, QuestionTextModel, settings, SurveyElement, SurveyModel, settings as surveySettings } from "survey-core";
 import { CreatorTester } from "./creator-tester";
 import { PageAdorner } from "../src/components/page";
 import { TabDesignerPlugin } from "../src/components/tabs/designer-plugin";
@@ -929,6 +929,34 @@ test("Check question converter with subitems (types)", (): any => {
   surveySettings.animationEnabled = true;
 });
 
+test("Check question converter on subitem search", (): any => {
+  surveySettings.animationEnabled = false;
+  const creator = new CreatorTester();
+
+  creator.JSON = {
+    elements: [
+      { type: "text", name: "q1" },
+    ]
+  };
+  const question = creator.survey.getQuestionByName("q1");
+  creator.selectElement(question);
+  const questionAdorner = new QuestionAdornerViewModel(
+    creator,
+    question,
+    <any>undefined
+  );
+
+  const list = getQuestionConverterList(creator, "q1");
+  list.filterString = "Email";
+  const filteredActions = list.renderedActions.filter(item => list.isItemVisible(item));
+  expect(filteredActions).toHaveLength(1);
+  filteredActions[0].action();
+  const questionConverted = creator.survey.getQuestionByName("q1") as QuestionTextModel;
+  expect(questionConverted.inputType).toBe("email");
+
+  surveySettings.animationEnabled = true;
+});
+
 test("Check question converter with single subitem (json)", (): any => {
   surveySettings.animationEnabled = false;
   const creator = new CreatorTester();