Skip to content

Conversation

@jtomasek
Copy link
Contributor

No description provided.

@jtomasek jtomasek force-pushed the 3.1-dashboard-extensions branch from 909c294 to 06c799f Compare September 16, 2024 11:03
@hardys hardys requested a review from ranjinimn September 23, 2024 08:33
Copy link
Collaborator

@ranjinimn ranjinimn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have completed my review and I had a few suggestions. Once they are incorporated, I will be happy to review again.

=== Installing with Rancher Dashboard UI

1. Click *Extensions* in the *Configuration* section of the navigation sidebar.
2. On the Extensions page click the three dot menu at the top right and select *Manage Repositories*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. On the Extensions page click the three dot menu at the top right and select *Manage Repositories*
2. On the Extensions page, click the three dot menu at the top right and select *Manage Repositories*.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

1. Click *Extensions* in the *Configuration* section of the navigation sidebar.
2. On the Extensions page click the three dot menu at the top right and select *Manage Repositories*
+
Each extension is distributed via it's own OCI artefact. Therefore it is required to add repositories for each extension we want to install.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, can we either use either artefact or artifact?

Also, jut another suggestion:

Each extension is distributed via it's own OCI artefact. Therefore, you need to add repositories for each extension that needs to be installed. 

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

+
Each extension is distributed via it's own OCI artefact. Therefore it is required to add repositories for each extension we want to install.

3. On the *Repositories page* click `Create` button.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. On the *Repositories page* click `Create` button.
3. On the *Repositories page*, click `Create`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Each extension is distributed via it's own OCI artefact. Therefore it is required to add repositories for each extension we want to install.

3. On the *Repositories page* click `Create` button.
4. In the form, specify the repository name and OCI artefact URL and click `Create`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. In the form, specify the repository name and OCI artefact URL and click `Create`
4. In the form, specify the repository name and OCI artefact URL, and click `Create`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


=== Installing with Rancher Dashboard UI

1. Click *Extensions* in the *Configuration* section of the navigation sidebar.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For numbering, instead of manual numbering, replace "1." with just "." "2." with ".", etc,. It will automatically provide the number.
For example:

. Click *Extensions* in the *Configuration* section of the navigation sidebar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

+
image::dashboard-extensions-create-oci-repository.png[]

5. The extension repository is added to the list and showing the `Active` state.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any action for the user here? Apart from seeing the status?

Suggested change
5. The extension repository is added to the list and showing the `Active` state.
. You can see that the extension repository is added to the list and is in `Active` state.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No subsequent action here.

Each extension is distributed via it's own OCI artefact. Therefore it is required to add repositories for each extension we want to install.

3. On the *Repositories page* click `Create` button.
4. In the form, specify the repository name and OCI artefact URL and click `Create`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. In the form, specify the repository name and OCI artefact URL and click `Create`
4. In the form, specify the repository name and OCI artefact URL and click `Create`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


7. On the extension card click `Install` and confirm the installation.
+
Once the extension is installed Rancher UI will prompt to reload the page as described in the `https://ranchermanager.docs.rancher.com/integrations-in-rancher/rancher-extensions#installing-extensions[Installing Extensions Rancher documentation page]`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Once the extension is installed Rancher UI will prompt to reload the page as described in the `https://ranchermanager.docs.rancher.com/integrations-in-rancher/rancher-extensions#installing-extensions[Installing Extensions Rancher documentation page]`.
Once the extension is installed Rancher UI prompts to reload the page as described in the `https://ranchermanager.docs.rancher.com/integrations-in-rancher/rancher-extensions#installing-extensions[Installing Extensions Rancher documentation page]`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jtomasek jtomasek force-pushed the 3.1-dashboard-extensions branch from 46bdcc5 to 988b43a Compare September 24, 2024 13:35
@jtomasek
Copy link
Contributor Author

Thanks for your review @ranjinimn! I've updated the PR with your suggestions.

@jtomasek jtomasek requested a review from ranjinimn September 24, 2024 13:38
@jdob
Copy link
Contributor

jdob commented Sep 24, 2024

While you're in here, can you look at the installation instructions for the plugin operator and see if we can pin them to versions? I'm a bit uncomfortable leaving them version-less. Here are the lines I'm talking about:

helm upgrade --create-namespace -n cattle-ui-plugin-system \
  --install ui-plugin-operator rancher-charts/ui-plugin-operator
helm upgrade --create-namespace -n cattle-ui-plugin-system \
  --install ui-plugin-operator-crd rancher-charts/ui-plugin-operator-crd

Copy link
Contributor

@jdob jdob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if there's a reason we don't pin the ui-plugin-operator to a specific version and I'll remove the request changes flag.

@jtomasek jtomasek force-pushed the 3.1-dashboard-extensions branch 2 times, most recently from 190819d to 6757bde Compare September 26, 2024 10:25
@jtomasek jtomasek force-pushed the 3.1-dashboard-extensions branch from 6757bde to 26e872b Compare September 26, 2024 11:52
@jtomasek jtomasek requested a review from jdob September 26, 2024 12:04
@jtomasek jtomasek merged commit ee2afb8 into suse-edge:main Sep 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants