-
Notifications
You must be signed in to change notification settings - Fork 40
Update Dashboard extensions documentation with OCI installation via Rancher UI #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
909c294 to
06c799f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have completed my review and I had a few suggestions. Once they are incorporated, I will be happy to review again.
| === Installing with Rancher Dashboard UI | ||
|
|
||
| 1. Click *Extensions* in the *Configuration* section of the navigation sidebar. | ||
| 2. On the Extensions page click the three dot menu at the top right and select *Manage Repositories* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 2. On the Extensions page click the three dot menu at the top right and select *Manage Repositories* | |
| 2. On the Extensions page, click the three dot menu at the top right and select *Manage Repositories*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| 1. Click *Extensions* in the *Configuration* section of the navigation sidebar. | ||
| 2. On the Extensions page click the three dot menu at the top right and select *Manage Repositories* | ||
| + | ||
| Each extension is distributed via it's own OCI artefact. Therefore it is required to add repositories for each extension we want to install. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, can we either use either artefact or artifact?
Also, jut another suggestion:
Each extension is distributed via it's own OCI artefact. Therefore, you need to add repositories for each extension that needs to be installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| + | ||
| Each extension is distributed via it's own OCI artefact. Therefore it is required to add repositories for each extension we want to install. | ||
|
|
||
| 3. On the *Repositories page* click `Create` button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 3. On the *Repositories page* click `Create` button. | |
| 3. On the *Repositories page*, click `Create`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| Each extension is distributed via it's own OCI artefact. Therefore it is required to add repositories for each extension we want to install. | ||
|
|
||
| 3. On the *Repositories page* click `Create` button. | ||
| 4. In the form, specify the repository name and OCI artefact URL and click `Create` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 4. In the form, specify the repository name and OCI artefact URL and click `Create` | |
| 4. In the form, specify the repository name and OCI artefact URL, and click `Create` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
|
||
| === Installing with Rancher Dashboard UI | ||
|
|
||
| 1. Click *Extensions* in the *Configuration* section of the navigation sidebar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For numbering, instead of manual numbering, replace "1." with just "." "2." with ".", etc,. It will automatically provide the number.
For example:
. Click *Extensions* in the *Configuration* section of the navigation sidebar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| + | ||
| image::dashboard-extensions-create-oci-repository.png[] | ||
|
|
||
| 5. The extension repository is added to the list and showing the `Active` state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any action for the user here? Apart from seeing the status?
| 5. The extension repository is added to the list and showing the `Active` state. | |
| . You can see that the extension repository is added to the list and is in `Active` state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No subsequent action here.
| Each extension is distributed via it's own OCI artefact. Therefore it is required to add repositories for each extension we want to install. | ||
|
|
||
| 3. On the *Repositories page* click `Create` button. | ||
| 4. In the form, specify the repository name and OCI artefact URL and click `Create` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 4. In the form, specify the repository name and OCI artefact URL and click `Create` | |
| 4. In the form, specify the repository name and OCI artefact URL and click `Create`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
|
||
| 7. On the extension card click `Install` and confirm the installation. | ||
| + | ||
| Once the extension is installed Rancher UI will prompt to reload the page as described in the `https://ranchermanager.docs.rancher.com/integrations-in-rancher/rancher-extensions#installing-extensions[Installing Extensions Rancher documentation page]`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Once the extension is installed Rancher UI will prompt to reload the page as described in the `https://ranchermanager.docs.rancher.com/integrations-in-rancher/rancher-extensions#installing-extensions[Installing Extensions Rancher documentation page]`. | |
| Once the extension is installed Rancher UI prompts to reload the page as described in the `https://ranchermanager.docs.rancher.com/integrations-in-rancher/rancher-extensions#installing-extensions[Installing Extensions Rancher documentation page]`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
46bdcc5 to
988b43a
Compare
|
Thanks for your review @ranjinimn! I've updated the PR with your suggestions. |
|
While you're in here, can you look at the installation instructions for the plugin operator and see if we can pin them to versions? I'm a bit uncomfortable leaving them version-less. Here are the lines I'm talking about: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if there's a reason we don't pin the ui-plugin-operator to a specific version and I'll remove the request changes flag.
190819d to
6757bde
Compare
Since Rancher 2.9 the ui-plugin-operator is built in the Rancher Dashboard. The code is deprecated https://github.com/rancher/ui-plugin-operator?tab=readme-ov-file and moved to Rancher dashboard controllers codebase https://github.com/rancher/rancher/tree/release/v2.9/pkg/controllers/dashboard/plugin
6757bde to
26e872b
Compare
No description provided.