BUG#27899274 - [MYSQL 8.0 GA DEBUG BUILD] ASSERTION `!IS_SET()' FAILED.

When mysqld is started with thread_stack option value of zero, an
ALTER TABLE DDL SQL asserts on debug build. The root cause is the
diagnostics area is set with a OK status whereas it has already
been set with an ERROR status.

The fix ensures the stack overrun error is propagated so that the
call to set the diagnostics area with OK status is avoided.

Author: thayumanavar77

mysql-test/r/alter_debug.result

@@ -0,0 +1,10 @@
+#
+# BUG#27899274 - [MYSQL 8.0 GA DEBUG BUILD] ASSERTION `!IS_SET()' FAILED.
+#
+#
+CREATE TABLE test.t1(col INT);
+SET SESSION debug= "+d, enable_stack_overrun_post_alter_commit";
+ALTER TABLE test.t1 ADD COLUMN col1 CHAR;
+Got one of the listed errors
+SET SESSION debug= "-d, enable_stack_overrun_post_alter_commit";
+DROP TABLE test.t1;

mysql-test/t/alter_debug.test

@@ -0,0 +1,15 @@
+--source include/have_debug.inc
+
+--echo #
+--echo # BUG#27899274 - [MYSQL 8.0 GA DEBUG BUILD] ASSERTION `!IS_SET()' FAILED.
+--echo #
+--echo #
+
+CREATE TABLE test.t1(col INT);
+SET SESSION debug= "+d, enable_stack_overrun_post_alter_commit";
+# Suppress exact error message as it contains numbers which may not be identical
+# across platforms
+--error ER_STACK_OVERRUN_NEED_MORE,ER_STACK_OVERRUN_NEED_MORE
+ALTER TABLE test.t1 ADD COLUMN col1 CHAR;
+SET SESSION debug= "-d, enable_stack_overrun_post_alter_commit";
+DROP TABLE test.t1;

storage/innobase/dict/dict0dd.cc

@@ -3343,8 +3343,12 @@ dberr_t dd_table_load_fk(dd::cache::Dictionary_client *client,
     mutex_exit(&dict_sys->mutex);
   }
 
+  DBUG_EXECUTE_IF("enable_stack_overrun_post_alter_commit",
+                  { DBUG_SET("+d,simulate_stack_overrun"); });
   err = dd_table_check_for_child(client, tbl_name, col_names, m_table, dd_table,
                                  thd, check_charsets, ignore_err, fk_tables);
+  DBUG_EXECUTE_IF("enable_stack_overrun_post_alter_commit",
+                  { DBUG_SET("-d,simulate_stack_overrun"); });
 
   if (dict_locked) {
     mutex_enter(&dict_sys->mutex);
@@ -4081,8 +4085,13 @@ dict_table_t *dd_open_table_one(dd::cache::Dictionary_client *client,
   /* Load foreign key info. It could also register child table(s) that
   refers to current table */
   if (exist == nullptr) {
-    dd_table_load_fk(client, norm_name, nullptr, m_table, &dd_table->table(),
-                     thd, false, true, &fk_list);
+    dberr_t error =
+        dd_table_load_fk(client, norm_name, nullptr, m_table,
+                         &dd_table->table(), thd, false, true, &fk_list);
+    if (error != DB_SUCCESS) {
+      dict_table_close(m_table, FALSE, FALSE);
+      m_table = nullptr;
+    }
   }
   mem_heap_free(heap);