refactoring

kousiknath · kousiknath · commit a895c997e87f · 2023-09-02T20:55:11.000+05:30
diff --git a/src/com/lld/kafka/MainApplication.java b/src/com/lld/kafka/MainApplication.java
@@ -1,15 +1,15 @@
-package lld.kafka;
-
-import lld.kafka.model.Consumer;
-import lld.kafka.model.ConsumerGroup;
-import lld.kafka.model.Producer;
-import lld.kafka.model.Topic;
-import lld.kafka.service.ConsumerService;
-import lld.kafka.service.TopicService;
-import lld.kafka.service.impl.ConsumerServiceImpl;
-import lld.kafka.service.impl.TopicServiceImpl;
-import lld.kafka.worker.ConsumerWorker;
-import lld.kafka.worker.ProducerWorker;
+package com.lld.kafka;
+
+import com.lld.kafka.model.Consumer;
+import com.lld.kafka.model.ConsumerGroup;
+import com.lld.kafka.model.Producer;
+import com.lld.kafka.model.Topic;
+import com.lld.kafka.service.ConsumerService;
+import com.lld.kafka.service.TopicService;
+import com.lld.kafka.service.impl.ConsumerServiceImpl;
+import com.lld.kafka.service.impl.TopicServiceImpl;
+import com.lld.kafka.worker.ConsumerWorker;
+import com.lld.kafka.worker.ProducerWorker;
 
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
diff --git a/src/com/lld/kafka/README.md b/src/com/lld/kafka/README.md
diff --git a/src/com/lld/kafka/model/Consumer.java b/src/com/lld/kafka/model/Consumer.java
@@ -1,4 +1,4 @@
-package lld.kafka.model;
+package com.lld.kafka.model;
 
 import java.util.UUID;
 
diff --git a/src/com/lld/kafka/model/ConsumerGroup.java b/src/com/lld/kafka/model/ConsumerGroup.java
@@ -1,4 +1,4 @@
-package lld.kafka.model;
+package com.lld.kafka.model;
 
 import java.util.*;
 import java.util.concurrent.locks.Lock;
diff --git a/src/com/lld/kafka/model/Message.java b/src/com/lld/kafka/model/Message.java
@@ -1,4 +1,4 @@
-package lld.kafka.model;
+package com.lld.kafka.model;
 
 import java.util.UUID;
 
diff --git a/src/com/lld/kafka/model/MessageMetadata.java b/src/com/lld/kafka/model/MessageMetadata.java
@@ -1,4 +1,4 @@
-package lld.kafka.model;
+package com.lld.kafka.model;
 
 public class MessageMetadata {
     Partition partition;
diff --git a/src/com/lld/kafka/model/Partition.java b/src/com/lld/kafka/model/Partition.java
@@ -1,4 +1,4 @@
-package lld.kafka.model;
+package com.lld.kafka.model;
 
 import java.util.ArrayList;
 import java.util.List;
diff --git a/src/com/lld/kafka/model/Producer.java b/src/com/lld/kafka/model/Producer.java
@@ -1,4 +1,4 @@
-package lld.kafka.model;
+package com.lld.kafka.model;
 
 import java.util.UUID;
 
diff --git a/src/com/lld/kafka/model/Topic.java b/src/com/lld/kafka/model/Topic.java
@@ -1,4 +1,4 @@
-package lld.kafka.model;
+package com.lld.kafka.model;
 
 import java.util.ArrayList;
 import java.util.List;
diff --git a/src/com/lld/kafka/repository/TopicRepository.java b/src/com/lld/kafka/repository/TopicRepository.java
@@ -1,6 +1,6 @@
-package lld.kafka.repository;
+package com.lld.kafka.repository;
 
-import lld.kafka.model.Topic;
+import com.lld.kafka.model.Topic;
 
 import java.util.HashMap;
 import java.util.Map;
diff --git a/src/com/lld/kafka/service/ConsumerGroupService.java b/src/com/lld/kafka/service/ConsumerGroupService.java
@@ -0,0 +1,11 @@
+package com.lld.kafka.service;
+
+import com.lld.kafka.model.Consumer;
+import com.lld.kafka.model.Message;
+import com.lld.kafka.model.Partition;
+import com.lld.kafka.model.Topic;
+
+public interface ConsumerGroupService {
+    Partition registerConsumer(Topic topic, Consumer consumer);
+    Message getAMessage(Consumer consumer);
+}
diff --git a/src/com/lld/kafka/service/ConsumerService.java b/src/com/lld/kafka/service/ConsumerService.java
@@ -0,0 +1,11 @@
+package com.lld.kafka.service;
+
+import com.lld.kafka.model.Consumer;
+import com.lld.kafka.model.Message;
+import com.lld.kafka.model.Partition;
+import com.lld.kafka.model.Topic;
+
+public interface ConsumerService {
+    Partition subscribe(Topic topic, Consumer consumer);
+    Message consume(Consumer consumer); // Clarify if you need to fetch in bulk
+}
diff --git a/src/com/lld/kafka/service/TopicService.java b/src/com/lld/kafka/service/TopicService.java
@@ -1,8 +1,8 @@
-package lld.kafka.service;
+package com.lld.kafka.service;
 
-import lld.kafka.model.Message;
-import lld.kafka.model.MessageMetadata;
-import lld.kafka.model.Topic;
+import com.lld.kafka.model.Message;
+import com.lld.kafka.model.MessageMetadata;
+import com.lld.kafka.model.Topic;
 
 public interface TopicService {
     Topic createTopic(String name, int numPartitions);
diff --git a/src/com/lld/kafka/service/impl/ConsumerGroupServiceImpl.java b/src/com/lld/kafka/service/impl/ConsumerGroupServiceImpl.java
@@ -1,7 +1,7 @@
-package lld.kafka.service.impl;
+package com.lld.kafka.service.impl;
 
-import lld.kafka.model.*;
-import lld.kafka.service.ConsumerGroupService;
+import com.lld.kafka.model.*;
+import com.lld.kafka.service.ConsumerGroupService;
 
 public class ConsumerGroupServiceImpl implements ConsumerGroupService {
     @Override
diff --git a/src/com/lld/kafka/service/impl/ConsumerServiceImpl.java b/src/com/lld/kafka/service/impl/ConsumerServiceImpl.java
@@ -1,11 +1,11 @@
-package lld.kafka.service.impl;
+package com.lld.kafka.service.impl;
 
-import lld.kafka.model.Consumer;
-import lld.kafka.model.Message;
-import lld.kafka.model.Partition;
-import lld.kafka.model.Topic;
-import lld.kafka.service.ConsumerGroupService;
-import lld.kafka.service.ConsumerService;
+import com.lld.kafka.model.Consumer;
+import com.lld.kafka.model.Message;
+import com.lld.kafka.model.Partition;
+import com.lld.kafka.model.Topic;
+import com.lld.kafka.service.ConsumerGroupService;
+import com.lld.kafka.service.ConsumerService;
 
 import java.util.Objects;
 
diff --git a/src/com/lld/kafka/service/impl/TopicServiceImpl.java b/src/com/lld/kafka/service/impl/TopicServiceImpl.java
@@ -1,12 +1,12 @@
-package lld.kafka.service.impl;
+package com.lld.kafka.service.impl;
 
-import lld.kafka.model.Message;
-import lld.kafka.model.MessageMetadata;
-import lld.kafka.model.Topic;
-import lld.kafka.repository.TopicRepository;
-import lld.kafka.service.TopicService;
-import lld.kafka.service.routing.strategy.RoutingStrategy;
-import lld.kafka.service.routing.strategy.impl.RoundRobinRoutingStrategy;
+import com.lld.kafka.model.Message;
+import com.lld.kafka.model.MessageMetadata;
+import com.lld.kafka.model.Topic;
+import com.lld.kafka.repository.TopicRepository;
+import com.lld.kafka.service.TopicService;
+import com.lld.kafka.service.routing.strategy.RoutingStrategy;
+import com.lld.kafka.service.routing.strategy.impl.RoundRobinRoutingStrategy;
 
 import java.util.Objects;
 
diff --git a/src/com/lld/kafka/service/routing/strategy/RoutingStrategy.java b/src/com/lld/kafka/service/routing/strategy/RoutingStrategy.java
@@ -0,0 +1,9 @@
+package com.lld.kafka.service.routing.strategy;
+
+import com.lld.kafka.model.Message;
+import com.lld.kafka.model.MessageMetadata;
+import com.lld.kafka.model.Topic;
+
+public interface RoutingStrategy {
+    MessageMetadata route(Topic topic, Message message);
+}
diff --git a/src/com/lld/kafka/service/routing/strategy/impl/RoundRobinRoutingStrategy.java b/src/com/lld/kafka/service/routing/strategy/impl/RoundRobinRoutingStrategy.java
@@ -1,10 +1,10 @@
-package lld.kafka.service.routing.strategy.impl;
+package com.lld.kafka.service.routing.strategy.impl;
 
-import lld.kafka.model.Message;
-import lld.kafka.model.MessageMetadata;
-import lld.kafka.model.Partition;
-import lld.kafka.model.Topic;
-import lld.kafka.service.routing.strategy.RoutingStrategy;
+import com.lld.kafka.model.Message;
+import com.lld.kafka.model.MessageMetadata;
+import com.lld.kafka.model.Partition;
+import com.lld.kafka.service.routing.strategy.RoutingStrategy;
+import com.lld.kafka.model.Topic;
 
 import java.util.Random;
 
diff --git a/src/com/lld/kafka/worker/ConsumerWorker.java b/src/com/lld/kafka/worker/ConsumerWorker.java
@@ -1,8 +1,8 @@
-package lld.kafka.worker;
+package com.lld.kafka.worker;
 
-import lld.kafka.model.Consumer;
-import lld.kafka.model.Message;
-import lld.kafka.service.ConsumerService;
+import com.lld.kafka.model.Consumer;
+import com.lld.kafka.model.Message;
+import com.lld.kafka.service.ConsumerService;
 
 public class ConsumerWorker implements Runnable {
     Consumer consumer;
diff --git a/src/com/lld/kafka/worker/ProducerWorker.java b/src/com/lld/kafka/worker/ProducerWorker.java
@@ -1,10 +1,10 @@
-package lld.kafka.worker;
+package com.lld.kafka.worker;
 
-import lld.kafka.model.Message;
-import lld.kafka.model.MessageMetadata;
-import lld.kafka.model.Producer;
-import lld.kafka.model.Topic;
-import lld.kafka.service.TopicService;
+import com.lld.kafka.model.Message;
+import com.lld.kafka.model.MessageMetadata;
+import com.lld.kafka.model.Producer;
+import com.lld.kafka.model.Topic;
+import com.lld.kafka.service.TopicService;
 
 import java.util.Random;
 
diff --git a/src/lld/kafka/service/ConsumerGroupService.java b/src/lld/kafka/service/ConsumerGroupService.java
diff --git a/src/lld/kafka/service/ConsumerService.java b/src/lld/kafka/service/ConsumerService.java
diff --git a/src/lld/kafka/service/routing/strategy/RoutingStrategy.java b/src/lld/kafka/service/routing/strategy/RoutingStrategy.java

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-package lld.kafka.model;`
	`1`	`+package com.lld.kafka.model;`
`2`	`2`
`3`	`3`	`import java.util.UUID;`
`4`	`4`