Skip to content

Commit 08ef649

Browse files
authored
Fix ReadEntryProcessor v2 SchedulingDelayStats (apache#3758)
Descriptions of the changes in this PR: ### Motivation We registered `ReadEntrySchedulingDelayStats` of `ReadEntryProcessor` as `WriteThreadQueuedLatency` mistakenly, so we need fix it. ### Changes Register `ReadEntrySchedulingDelayStats` if `ReadEntryProcessor`
1 parent 7f263fa commit 08ef649

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBase.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,8 +166,15 @@ protected void sendResponseAndWait(int rc, Object response, OpStatsLogger statsL
166166

167167
@Override
168168
public void run() {
169-
requestProcessor.getRequestStats().getWriteThreadQueuedLatency()
170-
.registerSuccessfulEvent(MathUtils.elapsedNanos(enqueueNanos), TimeUnit.NANOSECONDS);
169+
if (request instanceof BookieProtocol.ReadRequest) {
170+
requestProcessor.getRequestStats().getReadEntrySchedulingDelayStats()
171+
.registerSuccessfulEvent(MathUtils.elapsedNanos(enqueueNanos), TimeUnit.NANOSECONDS);
172+
}
173+
if (request instanceof BookieProtocol.ParsedAddRequest) {
174+
requestProcessor.getRequestStats().getWriteThreadQueuedLatency()
175+
.registerSuccessfulEvent(MathUtils.elapsedNanos(enqueueNanos), TimeUnit.NANOSECONDS);
176+
}
177+
171178
if (!isVersionCompatible()) {
172179
sendResponse(BookieProtocol.EBADVERSION,
173180
ResponseBuilder.buildErrorResponse(BookieProtocol.EBADVERSION, request),

0 commit comments

Comments
 (0)