Skip to content

Commit 4d01572

Browse files
authored
[deps] Fix dependency visibility in parent pom (javalin#1827)
1 parent 9f4cb13 commit 4d01572

File tree

1 file changed

+39
-32
lines changed

1 file changed

+39
-32
lines changed

pom.xml

Lines changed: 39 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -91,20 +91,20 @@
9191
<jackson.databind.version>2.14.1</jackson.databind.version>
9292
<jvmbrotli.version>0.2.0</jvmbrotli.version>
9393
<logback.version>1.4.5</logback.version>
94-
<swagger.ui.version>4.10.3</swagger.ui.version> <!-- used for testing webjars -->
9594
<slf4j.version>2.0.6</slf4j.version>
9695
<gson.version>2.10.1</gson.version>
96+
<okhttp.version>4.10.0</okhttp.version>
9797

9898
<!-- TEST DEPENDENCIES -->
9999
<assertj.version>3.23.1</assertj.version>
100100
<moshi.version>1.13.0</moshi.version>
101101
<java.websocket.version>1.5.2</java.websocket.version>
102102
<junit.version>5.7.2</junit.version>
103-
<okhttp.version>4.10.0</okhttp.version>
104103
<mockito.version>4.6.1</mockito.version>
105104
<unirest.version>3.13.10</unirest.version>
106105
<selenium.chrome.driver.version>4.4.0</selenium.chrome.driver.version>
107106
<webdrivermanager.version>5.2.3</webdrivermanager.version>
107+
<swagger.ui.version>4.10.3</swagger.ui.version> <!-- used for testing webjars -->
108108
</properties>
109109

110110
<dependencies>
@@ -193,6 +193,17 @@
193193
<artifactId>websocket-jetty-server</artifactId>
194194
<version>${jetty.version}</version>
195195
</dependency>
196+
<dependency>
197+
<groupId>org.eclipse.jetty</groupId>
198+
<artifactId>jetty-unixsocket</artifactId>
199+
<version>${jetty.version}</version>
200+
<type>pom</type>
201+
</dependency>
202+
<dependency>
203+
<groupId>org.eclipse.jetty</groupId>
204+
<artifactId>jetty-unixsocket-server</artifactId>
205+
<version>${jetty.version}</version>
206+
</dependency>
196207

197208
<!-- BEGIN Optional dependencies -->
198209
<dependency>
@@ -221,15 +232,14 @@
221232
<version>${jackson.version}</version>
222233
</dependency>
223234
<dependency>
224-
<groupId>org.webjars</groupId>
225-
<artifactId>swagger-ui</artifactId>
226-
<version>${swagger.ui.version}</version>
227-
<exclusions>
228-
<exclusion>
229-
<groupId>*</groupId>
230-
<artifactId>*</artifactId>
231-
</exclusion>
232-
</exclusions>
235+
<groupId>com.google.code.gson</groupId>
236+
<artifactId>gson</artifactId>
237+
<version>${gson.version}</version>
238+
</dependency>
239+
<dependency>
240+
<groupId>com.squareup.okhttp3</groupId>
241+
<artifactId>okhttp</artifactId>
242+
<version>${okhttp.version}</version>
233243
</dependency>
234244
<!-- END Optional dependencies -->
235245

@@ -238,16 +248,19 @@
238248
<groupId>org.junit.jupiter</groupId>
239249
<artifactId>junit-jupiter-api</artifactId>
240250
<version>${junit.version}</version>
251+
<scope>test</scope>
241252
</dependency>
242253
<dependency>
243254
<groupId>org.assertj</groupId>
244255
<artifactId>assertj-core</artifactId>
245256
<version>${assertj.version}</version>
257+
<scope>test</scope>
246258
</dependency>
247259
<dependency>
248260
<groupId>com.konghq</groupId>
249261
<artifactId>unirest-java</artifactId>
250262
<version>${unirest.version}</version>
263+
<scope>test</scope>
251264
</dependency>
252265
<dependency>
253266
<groupId>org.mockito</groupId>
@@ -259,16 +272,7 @@
259272
<groupId>org.java-websocket</groupId>
260273
<artifactId>Java-WebSocket</artifactId>
261274
<version>${java.websocket.version}</version>
262-
</dependency>
263-
<dependency>
264-
<groupId>com.squareup.okhttp3</groupId>
265-
<artifactId>okhttp</artifactId>
266-
<version>${okhttp.version}</version>
267-
</dependency>
268-
<dependency>
269-
<groupId>com.google.code.gson</groupId>
270-
<artifactId>gson</artifactId>
271-
<version>${gson.version}</version>
275+
<scope>test</scope>
272276
</dependency>
273277
<dependency>
274278
<groupId>com.squareup.moshi</groupId>
@@ -282,26 +286,29 @@
282286
<version>${moshi.version}</version>
283287
<scope>test</scope>
284288
</dependency>
285-
<dependency>
286-
<groupId>org.eclipse.jetty</groupId>
287-
<artifactId>jetty-unixsocket</artifactId>
288-
<version>${jetty.version}</version>
289-
<type>pom</type>
290-
</dependency>
291-
<dependency>
292-
<groupId>org.eclipse.jetty</groupId>
293-
<artifactId>jetty-unixsocket-server</artifactId>
294-
<version>${jetty.version}</version>
295-
</dependency>
296289
<dependency>
297290
<groupId>org.seleniumhq.selenium</groupId>
298291
<artifactId>selenium-chrome-driver</artifactId>
299292
<version>${selenium.chrome.driver.version}</version>
293+
<scope>test</scope>
300294
</dependency>
301295
<dependency>
302296
<groupId>io.github.bonigarcia</groupId>
303297
<artifactId>webdrivermanager</artifactId>
304298
<version>${webdrivermanager.version}</version>
299+
<scope>test</scope>
300+
</dependency>
301+
<dependency>
302+
<groupId>org.webjars</groupId>
303+
<artifactId>swagger-ui</artifactId>
304+
<version>${swagger.ui.version}</version>
305+
<scope>test</scope>
306+
<exclusions>
307+
<exclusion>
308+
<groupId>*</groupId>
309+
<artifactId>*</artifactId>
310+
</exclusion>
311+
</exclusions>
305312
</dependency>
306313
</dependencies>
307314
</dependencyManagement>

0 commit comments

Comments
 (0)