Skip to content

Commit 97ff3ba

Browse files
zugazagoitiazugazagoitia
authored
[pom] Move test dependencies from parent to submodule (javalin#1843)
1 parent 9719f10 commit 97ff3ba

File tree

4 files changed

+24
-72
lines changed

4 files changed

+24
-72
lines changed

‎javalin-micrometer/pom.xml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,13 @@
3636
<dependency>
3737
<groupId>org.junit.jupiter</groupId>
3838
<artifactId>junit-jupiter-api</artifactId>
39+
<version>${junit.version}</version>
3940
<scope>test</scope>
4041
</dependency>
4142
<dependency>
4243
<groupId>org.assertj</groupId>
4344
<artifactId>assertj-core</artifactId>
45+
<version>${assertj.version}</version>
4446
<scope>test</scope>
4547
</dependency>
4648
<dependency>

‎javalin-testtools/pom.xml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,13 @@
3838
<dependency>
3939
<groupId>org.junit.jupiter</groupId>
4040
<artifactId>junit-jupiter-api</artifactId>
41+
<version>${junit.version}</version>
4142
<scope>test</scope>
4243
</dependency>
4344
<dependency>
4445
<groupId>org.assertj</groupId>
4546
<artifactId>assertj-core</artifactId>
47+
<version>${assertj.version}</version>
4648
<scope>test</scope>
4749
</dependency>
4850
<dependency>

‎javalin/pom.xml‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,26 +70,31 @@
7070
<dependency>
7171
<groupId>org.junit.jupiter</groupId>
7272
<artifactId>junit-jupiter-api</artifactId>
73+
<version>${junit.version}</version>
7374
<scope>test</scope>
7475
</dependency>
7576
<dependency>
7677
<groupId>org.assertj</groupId>
7778
<artifactId>assertj-core</artifactId>
79+
<version>${assertj.version}</version>
7880
<scope>test</scope>
7981
</dependency>
8082
<dependency>
8183
<groupId>org.mockito</groupId>
8284
<artifactId>mockito-core</artifactId>
85+
<version>${mockito.version}</version>
8386
<scope>test</scope>
8487
</dependency>
8588
<dependency>
8689
<groupId>com.konghq</groupId>
8790
<artifactId>unirest-java</artifactId>
91+
<version>${unirest.version}</version>
8892
<scope>test</scope>
8993
</dependency>
9094
<dependency>
9195
<groupId>org.java-websocket</groupId>
9296
<artifactId>Java-WebSocket</artifactId>
97+
<version>${java.websocket.version}</version>
9398
<scope>test</scope>
9499
</dependency>
95100
<dependency>
@@ -100,11 +105,13 @@
100105
<dependency>
101106
<groupId>com.squareup.moshi</groupId>
102107
<artifactId>moshi</artifactId>
108+
<version>${moshi.version}</version>
103109
<scope>test</scope>
104110
</dependency>
105111
<dependency>
106112
<groupId>com.squareup.moshi</groupId>
107113
<artifactId>moshi-kotlin</artifactId>
114+
<version>${moshi.version}</version>
108115
<scope>test</scope>
109116
</dependency>
110117
<dependency>
@@ -115,17 +122,26 @@
115122
<dependency>
116123
<groupId>org.seleniumhq.selenium</groupId>
117124
<artifactId>selenium-chrome-driver</artifactId>
125+
<version>${selenium.chrome.driver.version}</version>
118126
<scope>test</scope>
119127
</dependency>
120128
<dependency>
121129
<groupId>io.github.bonigarcia</groupId>
122130
<artifactId>webdrivermanager</artifactId>
131+
<version>${webdrivermanager.version}</version>
123132
<scope>test</scope>
124133
</dependency>
125134
<dependency>
126135
<groupId>org.webjars</groupId>
127136
<artifactId>swagger-ui</artifactId>
137+
<version>${swagger.ui.version}</version>
128138
<scope>test</scope>
139+
<exclusions>
140+
<exclusion>
141+
<groupId>*</groupId>
142+
<artifactId>*</artifactId>
143+
</exclusion>
144+
</exclusions>
129145
</dependency>
130146
<dependency>
131147
<groupId>com.fasterxml.jackson.datatype</groupId>

‎pom.xml‎

Lines changed: 4 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@
2424
</license>
2525
</licenses>
2626
<scm>
27-
<connection>scm:git:[email protected]:tipsy/javalin.git</connection>
28-
<developerConnection>scm:git:[email protected]:tipsy/javalin.git</developerConnection>
29-
<url>https://github.com/tipsy/javalin.git</url>
27+
<connection>scm:git:[email protected]:javalin/javalin.git</connection>
28+
<developerConnection>scm:git:[email protected]:javalin/javalin.git</developerConnection>
29+
<url>https://github.com/javalin/javalin.git</url>
3030
<tag>HEAD</tag>
3131
</scm>
3232
<developers>
@@ -36,7 +36,7 @@
3636
</developers>
3737
<issueManagement>
3838
<system>GitHub Issue Tracker</system>
39-
<url>https://github.com/tipsy/javalin/issues</url>
39+
<url>https://github.com/javalin/javalin/issues</url>
4040
</issueManagement>
4141

4242
<distributionManagement>
@@ -232,74 +232,6 @@
232232
<version>${okhttp.version}</version>
233233
</dependency>
234234
<!-- END Optional dependencies -->
235-
236-
<!-- BEGIN Test dependencies -->
237-
<dependency>
238-
<groupId>org.junit.jupiter</groupId>
239-
<artifactId>junit-jupiter-api</artifactId>
240-
<version>${junit.version}</version>
241-
<scope>test</scope>
242-
</dependency>
243-
<dependency>
244-
<groupId>org.assertj</groupId>
245-
<artifactId>assertj-core</artifactId>
246-
<version>${assertj.version}</version>
247-
<scope>test</scope>
248-
</dependency>
249-
<dependency>
250-
<groupId>com.konghq</groupId>
251-
<artifactId>unirest-java</artifactId>
252-
<version>${unirest.version}</version>
253-
<scope>test</scope>
254-
</dependency>
255-
<dependency>
256-
<groupId>org.mockito</groupId>
257-
<artifactId>mockito-core</artifactId>
258-
<version>${mockito.version}</version>
259-
<scope>test</scope>
260-
</dependency>
261-
<dependency>
262-
<groupId>org.java-websocket</groupId>
263-
<artifactId>Java-WebSocket</artifactId>
264-
<version>${java.websocket.version}</version>
265-
<scope>test</scope>
266-
</dependency>
267-
<dependency>
268-
<groupId>com.squareup.moshi</groupId>
269-
<artifactId>moshi</artifactId>
270-
<version>${moshi.version}</version>
271-
<scope>test</scope>
272-
</dependency>
273-
<dependency>
274-
<groupId>com.squareup.moshi</groupId>
275-
<artifactId>moshi-kotlin</artifactId>
276-
<version>${moshi.version}</version>
277-
<scope>test</scope>
278-
</dependency>
279-
<dependency>
280-
<groupId>org.seleniumhq.selenium</groupId>
281-
<artifactId>selenium-chrome-driver</artifactId>
282-
<version>${selenium.chrome.driver.version}</version>
283-
<scope>test</scope>
284-
</dependency>
285-
<dependency>
286-
<groupId>io.github.bonigarcia</groupId>
287-
<artifactId>webdrivermanager</artifactId>
288-
<version>${webdrivermanager.version}</version>
289-
<scope>test</scope>
290-
</dependency>
291-
<dependency>
292-
<groupId>org.webjars</groupId>
293-
<artifactId>swagger-ui</artifactId>
294-
<version>${swagger.ui.version}</version>
295-
<scope>test</scope>
296-
<exclusions>
297-
<exclusion>
298-
<groupId>*</groupId>
299-
<artifactId>*</artifactId>
300-
</exclusion>
301-
</exclusions>
302-
</dependency>
303235
</dependencies>
304236
</dependencyManagement>
305237

0 commit comments

Comments
 (0)