Fixed increment read errors counter only on errors (oxia-db#308)

merlimat · web-flow · commit 0e7705cf73cc · 2023-04-05T06:51:15.000-07:00
diff --git a/server/kv/kv_pebble.go b/server/kv/kv_pebble.go
@@ -339,7 +339,7 @@ func (p *Pebble) Get(key string) ([]byte, io.Closer, error) {
 	value, closer, err := p.db.Get([]byte(key))
 	if errors.Is(err, pebble.ErrNotFound) {
 		err = ErrorKeyNotFound
-	} else {
+	} else if err != nil {
 		p.readErrors.Inc()
 	}
 	return value, closer, err

Original file line number	Diff line number	Diff line change
`@@ -339,7 +339,7 @@ func (p *Pebble) Get(key string) ([]byte, io.Closer, error) {`
`339`	`339`	`value, closer, err := p.db.Get([]byte(key))`
`340`	`340`	`if errors.Is(err, pebble.ErrNotFound) {`
`341`	`341`	`err = ErrorKeyNotFound`
`342`		`- } else {`
	`342`	`+ } else if err != nil {`
`343`	`343`	`p.readErrors.Inc()`
`344`	`344`	`}`
`345`	`345`	`return value, closer, err`