Skip to content

Commit 64cd753

Browse files
authored
[improve][bk] Improve getIsolationGroup by avoid creating arrayList (apache#20952)
### Motivation Minor improve `getIsolationGroup` by avoid creating arrayList. And it' beneficial to GC ### Modifications `new HashSet<>(Arrays.asList(...))` -> `Sets.newHashSet(...)`
1 parent d9538ea commit 64cd753

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

pulsar-broker-common/src/main/java/org/apache/pulsar/bookie/rackawareness/IsolatedBookieEnsemblePlacementPolicy.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
package org.apache.pulsar.bookie.rackawareness;
2020

2121
import static org.apache.pulsar.bookie.rackawareness.BookieRackAffinityMapping.METADATA_STORE_INSTANCE;
22+
import com.google.common.collect.Sets;
2223
import io.netty.util.HashedWheelTimer;
23-
import java.util.Arrays;
2424
import java.util.Collections;
2525
import java.util.HashSet;
2626
import java.util.List;
@@ -166,12 +166,12 @@ private static Pair<Set<String>, Set<String>> getIsolationGroup(
166166
String secondaryIsolationGroupString = ConfigurationStringUtil
167167
.castToString(properties.getOrDefault(SECONDARY_ISOLATION_BOOKIE_GROUPS, ""));
168168
if (!primaryIsolationGroupString.isEmpty()) {
169-
pair.setLeft(new HashSet<>(Arrays.asList(primaryIsolationGroupString.split(","))));
169+
pair.setLeft(Sets.newHashSet(primaryIsolationGroupString.split(",")));
170170
} else {
171171
pair.setLeft(Collections.emptySet());
172172
}
173173
if (!secondaryIsolationGroupString.isEmpty()) {
174-
pair.setRight(new HashSet<>(Arrays.asList(secondaryIsolationGroupString.split(","))));
174+
pair.setRight(Sets.newHashSet(secondaryIsolationGroupString.split(",")));
175175
} else {
176176
pair.setRight(Collections.emptySet());
177177
}

0 commit comments

Comments
 (0)