Skip to content

Commit 283125f

Browse files
Support pulsar packages for functions create/update (streamnative#1022)
1 parent cef63a8 commit 283125f

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

pkg/ctl/functions/update.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -364,8 +364,8 @@ func doUpdateFunctions(vc *cmdutils.VerbCmd, funcData *util.FunctionData) error
364364
updateOptions := util.NewUpdateOptions()
365365
updateOptions.UpdateAuthData = funcData.UpdateAuthData
366366

367-
if utils.IsPackageURLSupported(funcData.Jar) {
368-
err = admin.Functions().UpdateFunctionWithURL(funcData.FuncConf, funcData.Jar, updateOptions)
367+
if utils.IsPackageURLSupported(funcData.UserCodeFile) {
368+
err = admin.Functions().UpdateFunctionWithURL(funcData.FuncConf, funcData.UserCodeFile, updateOptions)
369369
if err != nil {
370370
cmdutils.PrintError(vc.Command.OutOrStderr(), err)
371371
} else {

pkg/ctl/utils/util.go

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,20 @@ const (
3333
FILE = "file"
3434
BUILTIN = "builtin"
3535

36+
FUNCTION = "function"
37+
SINK = "sink"
38+
SOURCE = "source"
39+
3640
PublicTenant = "public"
3741
DefaultNamespace = "default"
3842
)
3943

4044
func IsPackageURLSupported(functionPkgURL string) bool {
41-
return functionPkgURL != "" && strings.HasPrefix(functionPkgURL, HTTP) ||
42-
strings.HasPrefix(functionPkgURL, FILE)
45+
return functionPkgURL != "" && (strings.HasPrefix(functionPkgURL, HTTP) ||
46+
strings.HasPrefix(functionPkgURL, FILE) ||
47+
strings.HasPrefix(functionPkgURL, FUNCTION) ||
48+
strings.HasPrefix(functionPkgURL, SINK) ||
49+
strings.HasPrefix(functionPkgURL, SOURCE))
4350
}
4451

4552
func InferMissingFunctionName(funcConf *utils.FunctionConfig) {

0 commit comments

Comments
 (0)