fix: fix update sink (streamnative#873)

* fix: fix update sink

Signed-off-by: Zixuan Liu <[email protected]>

* Fix test

Signed-off-by: Zixuan Liu <[email protected]>

Author: nodece

pkg/ctl/sinks/update.go

@@ -255,6 +255,10 @@ func updateSinksCmd(vc *cmdutils.VerbCmd) {
 			"update-auth-data",
 			false,
 			"Whether or not to update the auth data")
+
+		flagSet.MarkDeprecated("auto-ack", "this value is immutable")
+		flagSet.MarkDeprecated("processing-guarantees", "this value is immutable")
+		flagSet.MarkDeprecated("retain-ordering", "this value is immutable")
 	})
 	vc.EnableOutputFlagSet()
 }
@@ -270,6 +274,15 @@ func doUpdateSink(vc *cmdutils.VerbCmd, sinkData *util.SinkData) error {
 
 	admin := cmdutils.NewPulsarClientWithAPIVersion(common.V3)
 
+	latestConfig, err := admin.Sinks().GetSink(sinkData.Tenant, sinkData.Namespace, sinkData.Name)
+	if err != nil {
+		return err
+	}
+
+	sinkData.SinkConf.AutoAck = latestConfig.AutoAck
+	sinkData.SinkConf.RetainOrdering = latestConfig.RetainOrdering
+	sinkData.SinkConf.ProcessingGuarantees = latestConfig.ProcessingGuarantees
+
 	updateOptions := util.NewUpdateOptions()
 	updateOptions.UpdateAuthData = sinkData.UpdateAuthData
 

pkg/ctl/sinks/update_test.go

@@ -31,6 +31,5 @@ func TestUpdateSink(t *testing.T) {
 	}
 	_, err, _ := TestSinksCommands(updateSinksCmd, failureUpdateArgs)
 	assert.NotNil(t, err)
-	failMsg := "Sink not-exist doesn't exist"
-	assert.True(t, strings.Contains(err.Error(), failMsg))
+	assert.True(t, strings.Contains(err.Error(), "404"))
 }