[SPARK-43979][SQL][FOLLOWUP] Fix the detection of alias-only project

### What changes were proposed in this pull request?

Fix a minor mistake in apache#42408 which is found during the branch 3.5 backport.
apache#42449 fixed it `branch-3.5` first.

### Why are the changes needed?

To make the code align with 3.5. We may remove `simplifyPlanForCollectedMetrics` entirely as it seems not an issue anymore in the master branch due to how we deduplicate relations.

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

existing tests

Closes apache#42453 from cloud-fan/minor.

Authored-by: Wenchen Fan <[email protected]>
Signed-off-by: Kent Yao <[email protected]>

Author: cloud-fan

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala

@@ -1113,9 +1113,12 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog with QueryErrorsB
   private def simplifyPlanForCollectedMetrics(plan: LogicalPlan): LogicalPlan = {
     plan.resolveOperators {
       case p: Project if p.projectList.size == p.child.output.size =>
-        val assignExprIdOnly = p.projectList.zip(p.child.output).forall {
-          case (left: Alias, right: Attribute) =>
-            left.child.semanticEquals(right) && right.name == left.name
+        val assignExprIdOnly = p.projectList.zipWithIndex.forall {
+          case (Alias(attr: AttributeReference, _), index) =>
+            // The input plan of this method is already canonicalized. The attribute id becomes the
+            // ordinal of this attribute in the child outputs. So an alias-only Project means the
+            // the id of the aliased attribute is the same as its index in the project list.
+            attr.exprId.id == index
           case _ => false
         }
         if (assignExprIdOnly) {