lib/api: Fix data race in TestCSRFRequired (syncthing#9006)

Author: emlun

lib/api/api_test.go

@@ -773,7 +773,7 @@ func TestCSRFRequired(t *testing.T) {
 
 	t.Run("/rest without a token should fail", func(t *testing.T) {
 		t.Parallel()
-		resp, err = cli.Get(baseURL + "/rest/system/config")
+		resp, err := cli.Get(baseURL + "/rest/system/config")
 		if err != nil {
 			t.Fatal("Unexpected error from getting /rest/system/config:", err)
 		}
@@ -787,7 +787,7 @@ func TestCSRFRequired(t *testing.T) {
 		t.Parallel()
 		req, _ := http.NewRequest("GET", baseURL+"/rest/system/config", nil)
 		req.Header.Set("X-"+csrfTokenName, csrfTokenValue)
-		resp, err = cli.Do(req)
+		resp, err := cli.Do(req)
 		if err != nil {
 			t.Fatal("Unexpected error from getting /rest/system/config:", err)
 		}
@@ -801,7 +801,7 @@ func TestCSRFRequired(t *testing.T) {
 		t.Parallel()
 		req, _ := http.NewRequest("GET", baseURL+"/rest/system/config", nil)
 		req.Header.Set("X-API-Key", testAPIKey+"X")
-		resp, err = cli.Do(req)
+		resp, err := cli.Do(req)
 		if err != nil {
 			t.Fatal("Unexpected error from getting /rest/system/config:", err)
 		}
@@ -815,7 +815,7 @@ func TestCSRFRequired(t *testing.T) {
 		t.Parallel()
 		req, _ := http.NewRequest("GET", baseURL+"/rest/system/config", nil)
 		req.Header.Set("Authorization", "Bearer "+testAPIKey+"X")
-		resp, err = cli.Do(req)
+		resp, err := cli.Do(req)
 		if err != nil {
 			t.Fatal("Unexpected error from getting /rest/system/config:", err)
 		}
@@ -829,7 +829,7 @@ func TestCSRFRequired(t *testing.T) {
 		t.Parallel()
 		req, _ := http.NewRequest("GET", baseURL+"/rest/system/config", nil)
 		req.Header.Set("X-API-Key", testAPIKey)
-		resp, err = cli.Do(req)
+		resp, err := cli.Do(req)
 		if err != nil {
 			t.Fatal("Unexpected error from getting /rest/system/config:", err)
 		}
@@ -843,7 +843,7 @@ func TestCSRFRequired(t *testing.T) {
 		t.Parallel()
 		req, _ := http.NewRequest("GET", baseURL+"/rest/system/config", nil)
 		req.Header.Set("Authorization", "Bearer "+testAPIKey)
-		resp, err = cli.Do(req)
+		resp, err := cli.Do(req)
 		if err != nil {
 			t.Fatal("Unexpected error from getting /rest/system/config:", err)
 		}