Skip to content

Commit c32ecfa

Browse files
timis1timis1
andauthored
JAVA-20464 Fix failing tests in hibernate-exceptions module (eugenp#13885)
* JAVA-20464 Fix failing tests in hibernate-exceptions module * JAVA-20464 Fix failing tests in hibernate-jpa module --------- Co-authored-by: timis1 <[email protected]>
1 parent d86604a commit c32ecfa

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

persistence-modules/hibernate-exceptions/src/test/java/com/baeldung/hibernate/exception/detachedentity/DetachedEntityUnitTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public void givenDetachedPost_whenTryingToPersist_thenThrowException() {
4242

4343
assertThatThrownBy(() -> session.persist(detachedPost))
4444
.isInstanceOf(PersistenceException.class)
45-
.hasMessageContaining("`org.hibernate.PersistentObjectException` to JPA `PersistenceException` : detached entity passed to persist");
45+
.hasMessageContaining("detached entity passed to persist: com.baeldung.hibernate.exception.detachedentity.entity.Post");
4646
}
4747

4848
@Test
@@ -71,13 +71,13 @@ public void givenDetachedPost_whenPersistingNewCommentWithIt_thenThrowException(
7171

7272
assertThatThrownBy(() -> session.persist(detachedPost))
7373
.isInstanceOf(PersistenceException.class)
74-
.hasMessageContaining("`org.hibernate.PersistentObjectException` to JPA `PersistenceException` : detached entity passed to persist");
74+
.hasMessageContaining("detached entity passed to persist: com.baeldung.hibernate.exception.detachedentity.entity.Post");
7575
}
7676

7777
@Test
7878
public void givenDetachedPost_whenMergeAndPersistComment_thenNoExceptionIsThrown() {
7979
Comment comment = new Comment("nice article!");
80-
Post mergedPost = (Post) session.merge(detachedPost);
80+
Post mergedPost = session.merge(detachedPost);
8181
comment.setPost(mergedPost);
8282

8383
session.persist(comment);

persistence-modules/hibernate-jpa/src/test/java/com/baeldung/hibernate/entitymanager/getreference/GetReferenceH2IntegrationTest.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,6 @@ public void whenUsingGetReferenceMethodToDeletePlayer_thenExecutesSelectForPlaye
136136
});
137137

138138
StringBuilder expected = new StringBuilder();
139-
expected.append("Hibernate: select ");
140-
expected.append("p1_0.id,g1_0.id,g1_0.name,p1_0.name ");
141-
expected.append("from Player p1_0 left join Game g1_0 on g1_0.id=p1_0.game_id where p1_0.id=?" + System.lineSeparator());
142139
expected.append("Hibernate: delete from Player where id=?" + System.lineSeparator());
143140

144141
assertEquals(expected.toString(), output.toString());
@@ -161,7 +158,7 @@ public void whenUsingFindMethodToUpdatePlayersGame_thenExecutesSelectForGame() {
161158
expected.append("Hibernate: select ");
162159
expected.append("p1_0.id,g1_0.id,g1_0.name,p1_0.name ");
163160
expected.append("from Player p1_0 left join Game g1_0 on g1_0.id=p1_0.game_id where p1_0.id=?" + System.lineSeparator());
164-
expected.append("Hibernate: update Player set game_id=?, name=? where id=?" + System.lineSeparator());
161+
expected.append("Hibernate: update Player set game_id=?,name=? where id=?" + System.lineSeparator());
165162

166163
assertEquals(expected.toString(), output.toString());
167164
}
@@ -182,7 +179,7 @@ public void whenUsingGetReferenceMethodToUpdatePlayersGame_thenDoesNotExecuteSel
182179
expected.append("Hibernate: select ");
183180
expected.append("p1_0.id,g1_0.id,g1_0.name,p1_0.name ");
184181
expected.append("from Player p1_0 left join Game g1_0 on g1_0.id=p1_0.game_id where p1_0.id=?" + System.lineSeparator());
185-
expected.append("Hibernate: update Player set game_id=?, name=? where id=?" + System.lineSeparator());
182+
expected.append("Hibernate: update Player set game_id=?,name=? where id=?" + System.lineSeparator());
186183

187184
assertEquals(expected.toString(), output.toString());
188185
}

persistence-modules/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
<module>hibernate-mapping-2</module>
3131
<!-- <module>hibernate-ogm</module>
3232
<module>hibernate-annotations</module> FAILED -->
33-
<!-- <module>hibernate-exceptions</module> FAILED -->
33+
<module>hibernate-exceptions</module>
3434
<module>hibernate-libraries</module>
3535
<module>hibernate-jpa</module>
3636
<!-- <module>hibernate-queries</module> FAILED -->

0 commit comments

Comments
 (0)