Merge pull request philc#3277 from gdh1995/fix-focus-of-hud

fix broken copy, paste and showFindMode since Chrome 74

Author: philc

content_scripts/hud.coffee

@@ -33,6 +33,7 @@ HUD =
   showFindMode: (@findMode = null) ->
     DomUtils.documentComplete =>
       @init()
+      @hudUI.toggleIframeElementClasses "vimiumUIComponentHidden", "vimiumUIComponentVisible"
       @hudUI.activate name: "showFindMode"
       @tween.fade 1.0, 150
 
@@ -92,7 +93,9 @@ HUD =
   copyToClipboard: (text) ->
     DomUtils.documentComplete =>
       @init()
-      @hudUI?.postMessage {name: "copyToClipboard", data: text}
+      # Chrome 74 only acknowledges text selection when a frame has been visible. See more in #3277 .
+      @hudUI.toggleIframeElementClasses "vimiumUIComponentHidden", "vimiumUIComponentVisible"
+      @hudUI.postMessage {name: "copyToClipboard", data: text}
 
   pasteFromClipboard: (@pasteListener) ->
     DomUtils.documentComplete =>

content_scripts/ui_component.coffee

@@ -8,7 +8,13 @@ class UIComponent
 
   toggleIframeElementClasses: (removeClass, addClass) ->
     @iframeElement.classList.remove removeClass
-    @iframeElement.classList.add addClass
+    unless @iframeElement.classList.contains addClass
+      @iframeElement.classList.add addClass
+      if addClass == "vimiumUIComponentVisible"
+        # Force to re-compute styles, so Chrome sends a visibility change message to the child frame at once.
+        # This block is to solve focusing issues since Chrome 74, and detailed explanation and trace is in
+        # https://github.com/philc/vimium/pull/3277#issuecomment-487363284
+        getComputedStyle(@iframeElement).display
 
   constructor: (iframeUrl, className, @handleMessage) ->
     DomUtils.documentReady =>

pages/hud.coffee

@@ -1,5 +1,11 @@
 findMode = null
 
+# Chrome creates a unique port for each MessageChannel,
+# so there's a race condition between JavaScript messages of Vimium and browser messages during style recomputation.
+# This constant is to ensure all messages have been received and handled
+# See more in https://github.com/philc/vimium/pull/3277#discussion_r283080348
+TIME_TO_WAIT_FOR_IPC_MESSAGES = 17
+
 # Set the input element's text, and move the cursor to the end.
 setTextInInputElement = (inputElement, text) ->
   inputElement.textContent = text
@@ -86,7 +92,7 @@ handlers =
     countElement.id = "hud-match-count"
     countElement.style.float = "right"
     hud.appendChild countElement
-    inputElement.focus()
+    Utils.setTimeout TIME_TO_WAIT_FOR_IPC_MESSAGES, -> inputElement.focus()
 
     findMode =
       historyIndex: -1
@@ -104,14 +110,14 @@ handlers =
       " (No matches)"
     countElement.textContent = if showMatchText then countText else ""
 
-  copyToClipboard: (data) ->
+  copyToClipboard: (data) -> Utils.setTimeout TIME_TO_WAIT_FOR_IPC_MESSAGES, ->
     focusedElement = document.activeElement
     Clipboard.copy data
     focusedElement?.focus()
     window.parent.focus()
     UIComponentServer.postMessage {name: "unfocusIfFocused"}
 
-  pasteFromClipboard: ->
+  pasteFromClipboard: -> Utils.setTimeout TIME_TO_WAIT_FOR_IPC_MESSAGES, ->
     focusedElement = document.activeElement
     data = Clipboard.paste()
     focusedElement?.focus()