Skip to content

Commit efe316b

Browse files
committed
Title -> Name
1 parent dc86dc1 commit efe316b

File tree

3 files changed

+31
-78
lines changed

3 files changed

+31
-78
lines changed

src/client/views/settings-view/clusters/clusters.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ export class Clusters extends React.Component<ClustersProps, ClustersState> {
114114
if (!newSettings.clusters.length) return this.renderEmpty();
115115

116116
const columns: SimpleTableColumn[] = [
117-
{label: 'Title', field: 'title', width: 200, cellIcon: require(`../../../icons/full-cluster.svg`) },
117+
{label: 'Name', field: 'title', width: 200, cellIcon: require(`../../../icons/full-cluster.svg`) },
118118
{label: 'Host', field: 'host', width: 200},
119119
{label: 'Type', field: 'type', width: 300}
120120
];

src/client/views/settings-view/data-cubes/data-cubes.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ export class DataCubes extends React.Component<DataCubesProps, DataCubesState> {
9595
if (!newSettings.dataCubes.length) return this.renderEmpty();
9696

9797
const columns: SimpleTableColumn[] = [
98-
{label: 'Title', field: 'title', width: 170, cellIcon: require(`../../../icons/full-cube.svg`) },
98+
{label: 'Name', field: 'title', width: 170, cellIcon: require(`../../../icons/full-cube.svg`) },
9999
{label: 'Source', field: 'source', width: 400},
100100
{label: 'Dimensions', field: (cube: DataCube) => cube.dimensions.size, width: 120},
101101
{label: 'Measures', field: (cube: DataCube) => cube.measures.size, width: 80}

src/common/models/labels.ts

Lines changed: 29 additions & 76 deletions
Original file line numberDiff line numberDiff line change
@@ -16,19 +16,29 @@
1616

1717
import { DataCube, Dimension, Measure, Cluster } from './index';
1818

19-
export const DIMENSION = {
19+
export const ATTRIBUTE = {
2020
name: {
21-
label: `Name (you won't be able to change this later)`,
22-
description: `The name of the dimension. This does not have to correspond to the
23-
attribute name (but the auto generated dimensions do). This should be a
24-
URL safe string. Changing this property will break any URLs that someone
25-
might have generated that include this dimension, that's why you can only
26-
set it once`
21+
label: `Name`,
22+
description: `The attribute's name`
23+
},
24+
type: {
25+
label: `Type`,
26+
description: `The attribute's type`
2727
},
28+
splittable: {
29+
label: `Splittable`,
30+
description: `Whether or not the attribute can be split on.`
31+
},
32+
special: {
33+
label: `Special`,
34+
description: `Special measures that are not numbers`
35+
}
36+
};
37+
38+
export const DIMENSION = {
2839
title: {
29-
label: `Title`,
30-
description: `The title for this dimension in the UI. Can be anything and is safe
31-
to change at any time.`
40+
label: `Name`,
41+
description: `The display name for this dimension in the UI.`
3242
},
3343
kind: {
3444
label: `Kind`,
@@ -55,37 +65,10 @@ export const DIMENSION = {
5565
}
5666
};
5767

58-
export const ATTRIBUTE = {
59-
name: {
60-
label: `Name`,
61-
description: `The attribute's name`
62-
},
63-
type: {
64-
label: `Type`,
65-
description: `The attribute's type`
66-
},
67-
splittable: {
68-
label: `Splittable`,
69-
description: `Whether or not the attribute can be split on.`
70-
},
71-
special: {
72-
label: `Special`,
73-
description: `Special measures that are not numbers`
74-
}
75-
};
76-
77-
7868
export const COLLECTION = {
79-
name: {
80-
label: `Name (you won't be able to change this later)`,
81-
description: `The name of the collection. This should be a
82-
URL safe string. Changing this property will break any URLs that someone
83-
might have generated that include this dimension, that's why you can only
84-
set it once`
85-
},
8669
title: {
8770
label: `Title`,
88-
description: `The title for this collection in the UI. Can be anything and is safe
71+
description: `The display name for this collection in the UI. Can be anything and is safe
8972
to change at any time.`
9073
},
9174
description: {
@@ -95,17 +78,9 @@ export const COLLECTION = {
9578
};
9679

9780
export const COLLECTION_ITEM = {
98-
name: {
99-
label: `Name (you won't be able to change this later)`,
100-
description: `The name of the collection item. This should be a
101-
URL safe string. Changing this property will break any URLs that someone
102-
might have generated that include this dimension, that's why you can only
103-
set it once`
104-
},
10581
title: {
106-
label: `Title`,
107-
description: `The title for this item in the UI. Can be anything and is safe
108-
to change at any time.`
82+
label: `Name`,
83+
description: `The display name for this item in the UI.`
10984
},
11085
description: {
11186
label: 'Description',
@@ -115,17 +90,9 @@ export const COLLECTION_ITEM = {
11590
};
11691

11792
export const MEASURE = {
118-
name: {
119-
label: `Name (you won't be able to change this later)`,
120-
description: `The name of the measure. This should be a
121-
URL safe string. Changing this property will break any URLs that someone
122-
might have generated that include this dimension, that's why you can only
123-
set it once`
124-
},
12593
title: {
126-
label: `Title`,
127-
description: `The title for this measure in the UI. Can be anything and is safe
128-
to change at any time.`
94+
label: `Name`,
95+
description: `The display name for this measure in the UI.`
12996
},
13097
units: {
13198
label: `Units`,
@@ -141,14 +108,8 @@ export const MEASURE = {
141108

142109
export const CLUSTER = {
143110
title: {
144-
label: 'Title',
145-
description: `The title of the Cluster in the UI. Can be anything and is
146-
safe to change at anytime`
147-
},
148-
149-
name: {
150111
label: 'Name',
151-
description: `The name of the cluster (to be referenced later from the data cube)`
112+
description: `The name of the Cluster in the UI.`
152113
},
153114
type: {
154115
label: 'Type',
@@ -204,7 +165,7 @@ export const CLUSTER = {
204165
description: 'The request decorator module filepath to load.'
205166
},
206167

207-
// PostGres + MySQL specific
168+
// Postgres + MySQL specific
208169
database: {
209170
label: 'Database',
210171
description: 'The database to which to connect to.'
@@ -233,17 +194,9 @@ export const GENERAL = {
233194
};
234195

235196
export const DATA_CUBE = {
236-
name: {
237-
label: 'Name',
238-
description: `The name of the data cube as used internally in Pivot and used in the
239-
URLs. This should be a URL safe string. Changing this property for a given
240-
data cube will break any URLs that someone might have generated for that
241-
data cube in the past.`
242-
},
243197
title: {
244-
label: 'Title',
245-
description: `The user visible name that will be used to describe this data cube in
246-
the UI. It is always safe to change this.`
198+
label: 'Name',
199+
description: `The user visible name that will be used to describe this data cube in the UI.`
247200
},
248201
description: {
249202
label: 'Description',

0 commit comments

Comments
 (0)