JUnit fixes for root suite "testsuite" (#100)

* tests to reproduce #98 and #99

* switch single test to passing test

* fix for #98 and #99

* additional specificity (helped to identify #99)

Author: bryanbcook

src/helpers/helper.js

@@ -19,6 +19,11 @@ const FORCED_ARRAY_KEYS = [
   "testsuites.testsuite.testcase.error",
   "testsuites.testsuite.testcase.system-err",
   "testsuites.testsuite.testcase.properties.property",
+  "testsuite.testcase",
+  "testsuite.testcase.failure",
+  "testsuite.testcase.error",
+  "testsuite.testcase.system-err",
+  "testsuite.testcase.properties.property",
   "assemblies",
   "assemblies.assembly",
   "assemblies.assembly.collection",

tests/data/junit/playwright-failures.xml

@@ -17,8 +17,7 @@
 <testcase name="has title" classname="example.spec.ts" time="0.475">
 </testcase>
 <testcase name="get started link" classname="example.spec.ts" time="5.433">
-<failure message="example.spec.ts:10:5 get started link" type="FAILURE">
-<![CDATA[  [chromium] › example.spec.ts:10:5 › get started link ─────────────────────────────────────────────
+<failure message="example.spec.ts:10:5 get started link" type="FAILURE"><![CDATA[  [chromium] › example.spec.ts:10:5 › get started link ─────────────────────────────────────────────
 
     Error: Timed out 5000ms waiting for expect(locator).toBeVisible()
 
@@ -42,8 +41,7 @@
     attachment #1: screenshot (image/png) ──────────────────────────────────────────────────────────
     test-results/example-get-started-link-chromium/test-failed-1.png
     ────────────────────────────────────────────────────────────────────────────────────────────────
-]]>
-</failure>
+]]></failure>
 <system-out>
 <![CDATA[
 [[ATTACHMENT|example-get-started-link-chromium/test-failed-1.png]]

tests/data/junit/testsuite-with-error.xml

@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<testsuite name="com.example.SampleTests" time="0.122" tests="2" errors="0" skipped="0" failures="1">
+  <testcase name="failingTest" classname="com.example.SampleTests" time="0.021">
+    <failure message="This test failed intentially" type="org.opentest4j.AssertionFailedError"><![CDATA[org.opentest4j.AssertionFailedError: This test failed intentially
+	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:38)
+	at org.junit.jupiter.api.Assertions.fail(Assertions.java:134)
+	at com.example.SampleTests.failingTest(SampleTests.java:19)
+	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
+	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
+	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
+]]></failure>
+  </testcase>
+  <testcase name="x" classname="com.example.SampleTests" time="0.101"/>
+</testsuite>

tests/data/junit/testsuite-with-singletest.xml

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<testsuite name="com.example.SampleTests" time="0.122" tests="1" errors="0" skipped="0" failures="0">
+  <testcase name="failingTest" classname="com.example.SampleTests" time="0.021"/>
+</testsuite>

tests/parser.junit.spec.js

@@ -496,6 +496,21 @@ describe('Parser - JUnit', () => {
     assert.equal(result.suites[0].cases.length, 2);
   });
 
+  it('can detect failures with testsuite root node', () => {
+    const result = parse({ type: 'junit', files: [`${testDataPath}/testsuite-with-error.xml`] });
+
+    assert.equal(result.total, 2);
+    assert.equal(result.failed, 1);
+    assert.equal(result.suites[0].cases[0].status, 'FAIL');
+  })
+
+  it('can detect single suite and single test case', () => {
+    const result = parse({ type: 'junit', files: [`${testDataPath}/testsuite-with-singletest.xml`] });
+
+    assert.equal(result.total, 1);
+    assert.equal(result.suites[0].cases[0].status, 'PASS');
+  })
+
   it('empty suite with no tests', () => {
     const result = parse({ type: 'junit', files: [`${testDataPath}/no-suites.xml`] });
     assert.deepEqual(result, {
@@ -638,6 +653,7 @@ describe('Parser - JUnit', () => {
     assert.equal(result.status, 'FAIL');
     assert.equal(result.suites[1].cases[1].attachments[0].name, `test-failed-1.png`);
     assert.equal(result.suites[1].cases[1].attachments[0].path, `example-get-started-link-chromium/test-failed-1.png`);
+    assert.equal(result.suites[1].cases[1].status, 'FAIL');
   });