Bug#35474089 RouterRoutingTest.ConnectTimeoutShutdownEarlyXProtocol fails

routertest_component_routing fails if DNS is slow to resolve with:

  router/tests/component/test_routing.cc:396: Failure
  Value of: res.error()
  Expected: (is equal to 2006) or (is equal to 2002)
    Actual: 2026 (of type int)
  router/tests/component/test_routing.cc:398:
  Failure
  Value of: res.what()
  Expected: (has substring "MySQL server has gone away") or (has substring
  "Connection refused connecting to")
    Actual: 0x7f389c01e210 pointing to "connecting to backend failed" (of
  type char const*)

The test waits 200ms for resolve() + connect(), but resolve() sometimes
takes longer to resolve the domain.

Change
------

- increase the sleep time of the test before expecting the connect() to
  be blocked.

Change-Id: Iaaa93111dbae265a86aac269922fa74a815a80f0

Author: weigon

router/tests/component/test_routing.cc

@@ -402,10 +402,16 @@ TEST_F(RouterRoutingTest, ConnectTimeoutShutdownEarlyXProtocol) {
   });
 
   const auto start = clock_type::now();
-  // give the connect thread chance to initiate the connection, even if it
-  // sometimes does not it should be fine, we just test a different scenario
-  // then
-  std::this_thread::sleep_for(200ms);
+
+  // give the connect thread enough time to:
+  //
+  // - resolve example.org (may take ~200ms)
+  // - start a connect() to its IP
+  //
+  // there is no better way to ensure that the connect() has been started
+  // and is still blocked other then waiting.
+
+  std::this_thread::sleep_for(500ms);
   // now force shutdown the router
   const auto kill_res = router.kill();
   EXPECT_EQ(0, kill_res);