Bug#35342521 Binary log purge should hold IX backup lock

Issue description
-----------------
PURGE BINARY LOGS and ALTER TABLE SECONDARY_LOG cannot be executed concurrently.

Analysis
--------
PURGE BINARY LOGS calls is_instance_backup_locked() to check if any other
process is holding BACKUP_LOCK and fails if it finds any. The lock is
not acquired for the duration of the PURGE BINARY LOGS statement which is
incorrect. As result it is possible that some other thread acquires
BACKUP_LOCK after PURGE has returned from is_instance_backup_locked().

Proposed solution
-----------------
PURGE BINARY LOG should acquire IX BACKUP_LOCK. Since IX locks
are compatible with each other, it will not block concurrent DDLs or get
blocked by them. Also, IX locks are not compatible with X locks, so PURGE
acquiring IX BACKUP_LOCK would also prevent a concurrent BACKUP from executing.

Change-Id: Ib0ccc8bea3fd0c2115246eb7fa50280f4292c3c4

Author: Slawomir Maludzinski

mysql-test/suite/binlog/r/binlog_alter_table_not_blocked_by_purge.result

@@ -0,0 +1,28 @@
+#
+# Initialization
+#
+RESET MASTER;
+CREATE TABLE t1 (c1 INT PRIMARY KEY) SECONDARY_ENGINE rapid;
+FLUSH BINARY LOGS;
+SHOW BINARY LOGS;
+Log_name	File_size	Encrypted
+binlog.000001	SIZE	No
+binlog.000002	SIZE	No
+#
+# Run PURGE BINARY LOGS in separate connection
+#
+[connection default]
+PURGE BINARY LOGS TO 'binlog.000001';
+[START] PURGE BINARY LOGS TO 'binlog.000001';
+#
+# Check ALTER TABLE statement can be executed
+#
+ALTER TABLE t1 SECONDARY_LOAD;
+#
+# Continue PURGE BINARY LOGS statement
+#
+[END] PURGE BINARY LOGS TO 'binlog.000001';
+#
+# Cleanup
+#
+DROP TABLE t1;

mysql-test/suite/binlog/r/binlog_backup_lock_purge_binary_logs.result

@@ -0,0 +1,33 @@
+#
+# Initialization
+#
+CREATE TABLE t1 (c INT);
+FLUSH BINARY LOGS;
+#
+# Lock the instance for backup using con1
+#
+LOCK INSTANCE FOR BACKUP;
+#
+# Check errors for purge operations
+#
+[connection default]
+PURGE BINARY LOGS TO 'BINLOG_FILE';
+ERROR HY000: Could not purge binary logs since another session is executing LOCK INSTANCE FOR BACKUP. Wait for that session to release the lock.
+PURGE BINARY LOGS BEFORE '2019-04-02 22:46:26';
+ERROR HY000: Could not purge binary logs since another session is executing LOCK INSTANCE FOR BACKUP. Wait for that session to release the lock.
+#
+# Unlock the instance for backup using con1
+#
+[connection con1]
+UNLOCK INSTANCE;
+#
+# Check no errors for purge operations
+#
+[connection default]
+PURGE BINARY LOGS TO 'BINLOG_FILE';
+PURGE BINARY LOGS BEFORE '2019-04-02 22:46:26';
+#
+# Cleanup
+#
+[connection default]
+DROP TABLE t1;

mysql-test/suite/binlog/r/binlog_backup_locked_by_flush_logs.result

@@ -0,0 +1,35 @@
+#
+# Initialization
+#
+RESET MASTER;
+CREATE TABLE t1 (c INT);
+FLUSH BINARY LOGS;
+SHOW BINARY LOGS;
+Log_name	File_size	Encrypted
+binlog.000001	SIZE	No
+binlog.000002	SIZE	No
+#
+# Execute FLUSH BINARY LOGS but stop on 'at_purge_logs_before_date' sync point
+#
+[connection default]
+[START] FLUSH BINARY LOGS;
+#
+# Check errors for LOCK INSTANCE FOR BACKUP operation
+#
+SET SESSION lock_wait_timeout = 1;
+LOCK INSTANCE FOR BACKUP;
+ERROR HY000: Lock wait timeout exceeded; try restarting transaction
+#
+# Continue FLUSH BINARY LOGS operation
+#
+[END] FLUSH BINARY LOGS;
+#
+# Check no errors for LOCK INSTANCE FOR BACKUP operation
+#
+LOCK INSTANCE FOR BACKUP;
+UNLOCK INSTANCE;
+#
+# Cleanup
+#
+[connection default]
+DROP TABLE t1;

mysql-test/suite/binlog/r/binlog_flush_logs_blocked_by_backup.result

@@ -0,0 +1,41 @@
+#
+# Initialize
+#
+SET @@global.binlog_expire_logs_seconds = 1;
+RESET MASTER;
+FLUSH BINARY LOGS;
+FLUSH BINARY LOGS;
+#
+# Lock instance for backup
+#
+[connection con1]
+LOCK INSTANCE FOR BACKUP;
+#
+# Flush binary logs so binary logs are purged
+#
+[connection default]
+include/save_error_log_position.inc
+FLUSH BINARY LOGS;
+#
+# Check that binary logs have not been purged
+#
+include/assert_error_log.inc [server: 1, pattern: Could not purge binary logs since another session is executing LOCK INSTANCE FOR BACKUP. Wait for that session to release the lock.]
+#
+# Unlock instance
+#
+[connection con1]
+UNLOCK INSTANCE;
+#
+# Generate log purge
+#
+[connection default]
+include/save_error_log_position.inc
+FLUSH BINARY LOGS;
+#
+# Check relay logs have been purged
+#
+include/assert_error_log.inc [server: 1, pattern: NONE]
+#
+# Cleanup
+#
+SET @@global.binlog_expire_logs_seconds = BINLOG_EXPIRE_LOGS_SECONDS_SAVED;

mysql-test/suite/binlog/r/binlog_purge_binary_logs_backup_lock.result

@@ -0,0 +1,36 @@
+#
+# Initialization
+#
+RESET MASTER;
+CREATE TABLE t1 (c INT);
+FLUSH BINARY LOGS;
+SHOW BINARY LOGS;
+Log_name	File_size	Encrypted
+binlog.000001	SIZE	No
+binlog.000002	SIZE	No
+#
+# Execute PURGE BINARY LOGS but stop on a sync point
+#
+[connection default]
+PURGE BINARY LOGS TO 'binlog.000001';
+[START] PURGE BINARY LOGS TO 'binlog.000001';
+#
+# Check errors for LOCK INSTANCE FOR BACKUP operation
+#
+SET SESSION lock_wait_timeout = 1;
+LOCK INSTANCE FOR BACKUP;
+ERROR HY000: Lock wait timeout exceeded; try restarting transaction
+#
+# Continue PURGE BINARY LOGS operation
+#
+[END] PURGE BINARY LOGS TO 'binlog.000001';
+#
+# Check no errors for LOCK INSTANCE FOR BACKUP operation
+#
+LOCK INSTANCE FOR BACKUP;
+UNLOCK INSTANCE;
+#
+# Cleanup
+#
+[connection default]
+DROP TABLE t1;

mysql-test/suite/binlog/r/binlog_purge_not_blocked_by_alter_table.result

@@ -0,0 +1,27 @@
+#
+# Initialization
+#
+RESET MASTER;
+CREATE TABLE t1 (c1 INT PRIMARY KEY) SECONDARY_ENGINE rapid;
+FLUSH BINARY LOGS;
+SHOW BINARY LOGS;
+Log_name	File_size	Encrypted
+binlog.000001	SIZE	No
+binlog.000002	SIZE	No
+#
+# Run ALTER TABLE in separate connection
+#
+[connection default]
+[START] ALTER TABLE t1 SECONDARY_LOAD;
+#
+# Check PURGE BINARY LOGS can be executed
+#
+PURGE BINARY LOGS TO 'BINLOG_FILE';
+#
+# Continue ALTER TABLE statement
+#
+[END] ALTER TABLE t1 SECONDARY_LOAD;
+#
+# Cleanup
+#
+DROP TABLE t1;

mysql-test/suite/binlog/t/binlog_alter_table_not_blocked_by_purge.test

@@ -0,0 +1,65 @@
+# === Purpose ===
+# Check ALTER TABLE operation can be executed with PURGE BINARY LOGS.
+#
+# === Requirements ===
+# R1. ALTER TABLE can be executed with PURGE BINARY LOGS statement.
+#
+# === Implementation ===
+# 1. Create table
+# 2. Run PURGE BINARY LOGS statement but stop on a sync point
+# 3. Check ALTER TABLE statement can be executed
+# 4. Cleanup
+#
+# === References ===
+#
+# Bug#35342521	Binary log purge should hold IX backup lock
+#
+--source include/have_debug_sync.inc
+--source include/have_binlog_format_row.inc
+
+--echo #
+--echo # Initialization
+--echo #
+
+RESET MASTER;
+CREATE TABLE t1 (c1 INT PRIMARY KEY) SECONDARY_ENGINE rapid;
+
+--let $binlog_file = query_get_value(SHOW MASTER STATUS, File, 1)
+FLUSH BINARY LOGS;
+--replace_column 2 SIZE
+SHOW BINARY LOGS;
+
+--echo #
+--echo # Run PURGE BINARY LOGS in separate connection
+--echo #
+
+--connect (con1, localhost, root,,)
+
+--let $rpl_connection_name = default
+--source include/rpl_connection.inc
+
+--eval PURGE BINARY LOGS TO '$binlog_file'
+--let $statement_connection = con1
+--let $statement = PURGE BINARY LOGS TO '$binlog_file'
+--let $sync_point = before_purge_logs
+--source include/execute_to_sync_point.inc
+
+--echo #
+--echo # Check ALTER TABLE statement can be executed
+--echo #
+
+--disable_warnings
+ALTER TABLE t1 SECONDARY_LOAD;
+--enable_warnings
+
+--echo #
+--echo # Continue PURGE BINARY LOGS statement
+--echo #
+
+--source include/execute_from_sync_point.inc
+
+--echo #
+--echo # Cleanup
+--echo #
+
+DROP TABLE t1;

mysql-test/suite/binlog/t/binlog_backup_lock_purge_binary_logs.test

@@ -0,0 +1,82 @@
+# === Purpose ===
+# Check PURGE BINARY LOGS operation is mutually exclusive with BACKUP lock.
+#
+# === Requirements ===
+# R1. PURGE BINARY LOGS must be mutually exclusive with BACKUP operation.
+#
+# === Implementation ===
+#
+# 1. Create database and tables
+# 2. Create second connection
+# 2.1. LOCK INSTANCE FOR BACKUP
+# 3. Use first connection
+# 3.1. Check PURGE BINARY LOGS TO/BEFORE cannot proceed
+# 4. Use second connection
+# 4.1. UNLOCK INSTANCE
+# 5. Check PURGE BINARY LOGS TO/BEFORE can proceed
+# 6. Cleanup
+#
+# === References ===
+#
+# Bug#35342521	Binary log purge should hold IX backup lock
+#
+--source include/have_debug.inc
+--source include/have_binlog_format_row.inc
+
+--echo #
+--echo # Initialization
+--echo #
+
+CREATE TABLE t1 (c INT);
+--let $binlog_file = query_get_value(SHOW MASTER STATUS, File, 1)
+FLUSH BINARY LOGS;
+
+--echo #
+--echo # Lock the instance for backup using con1
+--echo #
+
+--connect (con1, localhost, root,,)
+LOCK INSTANCE FOR BACKUP;
+
+--echo #
+--echo # Check errors for purge operations
+--echo #
+
+--let $rpl_connection_name = default
+--source include/rpl_connection.inc
+
+--replace_result $binlog_file BINLOG_FILE
+--error ER_CANNOT_PURGE_BINLOG_WITH_BACKUP_LOCK
+--eval PURGE BINARY LOGS TO '$binlog_file'
+
+--error ER_CANNOT_PURGE_BINLOG_WITH_BACKUP_LOCK
+PURGE BINARY LOGS BEFORE '2019-04-02 22:46:26';
+
+--echo #
+--echo # Unlock the instance for backup using con1
+--echo #
+
+--let $rpl_connection_name = con1
+--source include/rpl_connection.inc
+UNLOCK INSTANCE;
+
+--echo #
+--echo # Check no errors for purge operations
+--echo #
+
+--let $rpl_connection_name = default
+--source include/rpl_connection.inc
+
+--replace_result $binlog_file BINLOG_FILE
+--eval PURGE BINARY LOGS TO '$binlog_file'
+
+PURGE BINARY LOGS BEFORE '2019-04-02 22:46:26';
+
+--echo #
+--echo # Cleanup
+--echo #
+
+--let $rpl_connection_name = default
+--source include/rpl_connection.inc
+
+DROP TABLE t1;