PrestoDB: make password/schema/catalog optional, fix datediff syntax (growthbook#272)

Author: jdorn

packages/back-end/src/integrations/Athena.ts

@@ -36,4 +36,7 @@ export default class Athena extends SqlIntegration {
   formatDate(col: string): string {
     return `substr(to_iso8601(${col}),0,10)`;
   }
+  dateDiff(startCol: string, endCol: string) {
+    return `date_diff('day', ${startCol}, ${endCol})`;
+  }
 }

packages/back-end/src/integrations/Presto.ts

@@ -84,4 +84,7 @@ export default class Presto extends SqlIntegration {
   formatDate(col: string): string {
     return `substr(to_iso8601(${col}),0,10)`;
   }
+  dateDiff(startCol: string, endCol: string) {
+    return `date_diff('day', ${startCol}, ${endCol})`;
+  }
 }

packages/front-end/components/Settings/PrestoForm.tsx

@@ -72,7 +72,6 @@ const PrestoForm: FC<{
           type="text"
           className="form-control"
           name="password"
-          required={!existing}
           value={params.password || ""}
           onChange={onParamChange}
           placeholder={existing ? "(Keep existing)" : ""}
@@ -84,7 +83,6 @@ const PrestoForm: FC<{
           type="text"
           className="form-control"
           name="catalog"
-          required
           value={params.catalog || ""}
           onChange={onParamChange}
         />
@@ -95,7 +93,6 @@ const PrestoForm: FC<{
           type="text"
           className="form-control"
           name="schema"
-          required
           value={params.schema || ""}
           onChange={onParamChange}
         />