Skip to content

Conversation

@samuel-w
Copy link
Contributor

@samuel-w samuel-w commented Aug 2, 2020

Currently the client fails when running a command without internet, even when the command is cached. For example, tldr df with internet disconnected returns

Error fetching from tldr: <urlopen error [Errno -3] Temporary failure in name resolution>

@MasterOdin
Copy link
Contributor

While I get and like the general intention here of having tldr client work without internet, I dislike that we lose error reporting that a page was not found potentially due to internet connections instead of just serving up a generic "Page could not be found" error which is just going to confuse people if they do have internet (but are blocked via proxy or whatever).

We should probably "remember" the failed internet error and that if we go through all page candidates and none were found, then display the failed internet error, rather than fallback to the generic one.

@samuel-w samuel-w changed the title Continue on internet connection failure Make client work without internet Aug 4, 2020
@samuel-w
Copy link
Contributor Author

samuel-w commented Aug 4, 2020

OK, I've changed it.

@samuel-w samuel-w closed this Nov 8, 2020
@samuel-w samuel-w deleted the internetbug branch November 8, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants