-
-
Notifications
You must be signed in to change notification settings - Fork 109
Improve wording of missing page error message #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
How about we use the same message as
|
|
Sure, I don't see a problem with that. |
tldr.py
Outdated
| sys.exit(( | ||
| "`{cmd}` documentation is not available. " | ||
| "Consider contributing Pull Request to " | ||
| "If you want to contribute it, feel free to send a pull request to:" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might need to add a new line like the rest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, add a newline after just the first line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@MasterOdin I don't see the problem here. Is it setup to run with 3 lines instead of 4, or have I made a mistake? |
|
@MasterOdin You know the backend to this, I am sure you will look at this and find a fix within 20 seconds, because you know how this works. Sorry for creating 9 waste commits, we'll squash when merging. |
|
@CleanMachine1 No problem! I made a commit that resolves the test failures. Don't worry about squashing on your end, I will handle doing that when I go to merge the PR. |
|
Ok, well, I'll leave this in your hands in terms of merging. But I have 1 question, how long will this simple change take till this in the Arch Repos' |
I'm not sure as I have no hand in maintaining it. In the past it's been decently quick to update. |
|
Normally at a tag I think at least |
I am surprised that this issue has gone unnoticed, it must be because we have so pages documented ;)
Also I don't know whether you agree with the de-capitalization, however I feel this is correct since with using the word
PRs, you are indicating that they are a part of an acronym