Skip to content

Conversation

@CleanMachine1
Copy link
Member

I am surprised that this issue has gone unnoticed, it must be because we have so pages documented ;)

Also I don't know whether you agree with the de-capitalization, however I feel this is correct since with using the word PRs, you are indicating that they are a part of an acronym

@marchersimon
Copy link

How about we use the same message as tldr-node-client:

If you want to contribute it, feel free to send a pull request to: https://www.github.com/tldr-pages/tldr.

@CleanMachine1
Copy link
Member Author

Sure, I don't see a problem with that.

tldr.py Outdated
sys.exit((
"`{cmd}` documentation is not available. "
"Consider contributing Pull Request to "
"If you want to contribute it, feel free to send a pull request to:"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might need to add a new line like the rest

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, add a newline after just the first line.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CleanMachine1
Copy link
Member Author

@MasterOdin I don't see the problem here. Is it setup to run with 3 lines instead of 4, or have I made a mistake?

@CleanMachine1
Copy link
Member Author

@MasterOdin You know the backend to this, I am sure you will look at this and find a fix within 20 seconds, because you know how this works.

Sorry for creating 9 waste commits, we'll squash when merging.

@MasterOdin
Copy link
Contributor

@CleanMachine1 No problem! I made a commit that resolves the test failures. Don't worry about squashing on your end, I will handle doing that when I go to merge the PR.

@CleanMachine1
Copy link
Member Author

Ok, well, I'll leave this in your hands in terms of merging.

But I have 1 question, how long will this simple change take till this in the Arch Repos'

@MasterOdin MasterOdin changed the title fixed missing a & removed caps Improve wording of missing page error message Jul 19, 2021
@MasterOdin MasterOdin merged commit 59d9dec into main Jul 19, 2021
@MasterOdin MasterOdin deleted the error-message-fix branch July 19, 2021 22:44
@MasterOdin
Copy link
Contributor

But I have 1 question, how long will this simple change take till this in the Arch Repos'

I'm not sure as I have no hand in maintaining it. In the past it's been decently quick to update.

@CleanMachine1
Copy link
Member Author

Normally at a tag I think at least

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants