Change TLDR_CACHE_MAX_AGE default #170
Conversation
|
Do I need to remove the comments? |
marchersimon
left a comment
marchersimon
left a comment
There was a problem hiding this comment.
I agree with the changes, but I think the added comments are not really necessary. Either way, thanks
sbrl
left a comment
sbrl
left a comment
There was a problem hiding this comment.
Thanks, @CleanMachine1!
Looking at the commit history let's wait for @MasterOdin to merge this?
|
Hrm, some of the builds are failing here? |
Those are all because of the comments. As already said, I don't think they're necessary. |
|
@MasterOdin Could we get a review? |
README.md
Outdated
| * If set to `1`, the client will first try to load from cache, and fall back to fetching from the internet if the cache doesn't exist or is too old. | ||
| * If set to `0`, the client will fetch from the internet, and fall back to the cache if the page cannot be fetched from the internet. | ||
| * `TLDR_CACHE_MAX_AGE` (default is `24`): maximum age of the cache in hours to be considered as valid when `TLDR_CACHE_ENABLED` is set to `1`. | ||
| * `TLDR_CACHE_MAX_AGE` (default is `168`): maximum age of the cache in hours to be considered as valid when `TLDR_CACHE_ENABLED` is set to `1`. |
There was a problem hiding this comment.
Can we specify what 168 is here?
(default is
168hours, or one week)
tldr.py
Outdated
| USE_NETWORK = int(os.environ.get('TLDR_NETWORK_ENABLED', '1')) > 0 | ||
| USE_CACHE = int(os.environ.get('TLDR_CACHE_ENABLED', '1')) > 0 | ||
| MAX_CACHE_AGE = int(os.environ.get('TLDR_CACHE_MAX_AGE', 24)) | ||
| MAX_CACHE_AGE = int(os.environ.get('TLDR_CACHE_MAX_AGE', 168)) |
There was a problem hiding this comment.
Can you change this to be 24 * 7? Makes it a bit easier to quickly parse.
|
Can I get some reviews here please |
5 participants
I feel 24 hours is extreme, and it annoys me when I first started using this client.
On average I probably only use tldr 1-2 times a day, therefore I have to wait each time for it to download a new cache everyday, which normally includes the additions of 0-10 pages/changes.
It goes from nearly instant with using an out of date cache to waiting a few seconds for a command if you use an updated cache which is just slightly annoying.
Simple change, however others may find this controversial 🤷
edit: PS, I forgot to mention that I had already changed the cache date for my .zshrc a weeks back, however the change I made, I felt needed to be standardized