Skip to content

Commit 9da8052

Browse files
committed
Replacing use of deserialise with more flexible add method.
1 parent 0b59a4a commit 9da8052

File tree

2 files changed

+4
-25
lines changed

2 files changed

+4
-25
lines changed

lib/QueryBuilder.js

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@ function _toConsumableArray(arr) { if (Array.isArray(arr)) { for (var i = 0, arr
1919
function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }
2020

2121
var QueryBuilder = function () {
22-
function QueryBuilder(importArray) {
22+
function QueryBuilder() {
2323
_classCallCheck(this, QueryBuilder);
2424

2525
this._currentQuery = [];
26-
this.deserialise(importArray);
26+
this.add.apply(this, arguments);
2727
}
2828

2929
_createClass(QueryBuilder, [{
@@ -116,18 +116,6 @@ var QueryBuilder = function () {
116116
}
117117
return this;
118118
}
119-
}, {
120-
key: 'deserialise',
121-
value: function deserialise(importArray) {
122-
var _this3 = this;
123-
124-
if (Array.isArray(importArray)) {
125-
importArray.forEach(function (item) {
126-
_this3._currentQuery.push(item);
127-
});
128-
}
129-
return this;
130-
}
131119
}, {
132120
key: 'serialise',
133121
value: function serialise() {

src/QueryBuilder.js

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import clone from 'clone'
22

33
export default class QueryBuilder {
4-
constructor(importArray) {
4+
constructor(...args) {
55
this._currentQuery = []
6-
this.deserialise(importArray)
6+
this.add(...args)
77
}
88

99
_addItemToCurrentQuery(fieldKey, comparator, value) {
@@ -77,15 +77,6 @@ export default class QueryBuilder {
7777
return this
7878
}
7979

80-
deserialise(importArray) {
81-
if (Array.isArray(importArray)) {
82-
importArray.forEach((item) => {
83-
this._currentQuery.push(item)
84-
})
85-
}
86-
return this
87-
}
88-
8980
serialise() {
9081
return this._currentQuery
9182
}

0 commit comments

Comments
 (0)