Enable CA1805 diagnostics (dotnet#32893)

* Enable CA1805 diagnostics

Author: pranavkm

.editorconfig

@@ -85,9 +85,12 @@ dotnet_diagnostic.CA1507.severity = warning
 # CA1725: Parameter names should match base declaration
 dotnet_diagnostic.CA1725.severity = suggestion
 
-# CA1823: Use literals where appropriate
+# CA1802: Use literals where appropriate
 dotnet_diagnostic.CA1802.severity = warning
 
+# CA1805: Do not initialize unnecessarily
+dotnet_diagnostic.CA1805.severity = warning
+
 # CA1823: Avoid unused private fields
 dotnet_diagnostic.CA1823.severity = warning
 
@@ -98,12 +101,14 @@ dotnet_diagnostic.CA2012.severity = warning
 # CA1823: Use literals where appropriate
 dotnet_diagnostic.CA1802.severity = suggestion
 
-[**/{test,perf}/**.{cs,vb}]
+[**/{test,samples,perf}/**.{cs,vb}]
 # CA1018: Mark attributes with AttributeUsageAttribute
 dotnet_diagnostic.CA1018.severity = suggestion
 # CA1507: Use nameof to express symbol names
 dotnet_diagnostic.CA1507.severity = suggestion
-# CA1823: Use literals where appropriate
+# CA1802: Use literals where appropriate
 dotnet_diagnostic.CA1802.severity = suggestion
+# CA1805: Do not initialize unnecessarily
+dotnet_diagnostic.CA1805.severity = suggestion
 # CA2012: Use ValueTask correctly
 dotnet_diagnostic.CA2012.severity = suggestion

src/Components/Components/src/RenderTree/Renderer.cs

@@ -37,7 +37,7 @@ public abstract partial class Renderer : IDisposable, IAsyncDisposable
         private readonly ComponentFactory _componentFactory;
         private List<(ComponentState, ParameterView)>? _rootComponents;
 
-        private int _nextComponentId = 0;
+        private int _nextComponentId;
         private bool _isBatchInProgress;
         private ulong _lastEventHandlerId;
         private List<Task>? _pendingTasks;

src/Components/Components/src/Rendering/ParameterViewLifetime.cs

@@ -10,7 +10,7 @@ internal readonly struct ParameterViewLifetime
         private readonly RenderBatchBuilder _owner;
         private readonly int _stamp;
 
-        public static readonly ParameterViewLifetime Unbound = default;
+        public static readonly ParameterViewLifetime Unbound;
 
         public ParameterViewLifetime(RenderBatchBuilder owner)
         {

src/Components/Components/src/Routing/Router.cs

@@ -36,7 +36,7 @@ static readonly IReadOnlyDictionary<string, object> _emptyParametersDictionary
 
         private RouteKey _routeTableLastBuiltForRouteKey;
 
-        private bool _onNavigateCalled = false;
+        private bool _onNavigateCalled;
 
         [Inject] private NavigationManager NavigationManager { get; set; }
 

src/Components/Server/src/BlazorPack/SequenceOfT.cs

@@ -84,7 +84,7 @@ public Sequence(ArrayPool<T> arrayPool)
         /// in which case the higher of the two minimums dictate the minimum array size that will be allocated.
         /// </para>
         /// </remarks>
-        public int MinimumSpanLength { get; set; } = 0;
+        public int MinimumSpanLength { get; set; }
 
         /// <summary>
         /// Gets this sequence expressed as a <see cref="ReadOnlySequence{T}"/>.

src/Components/Server/src/Circuits/RemoteRenderer.cs

@@ -22,7 +22,7 @@ internal class RemoteRenderer : Microsoft.AspNetCore.Components.RenderTree.Rende
         private readonly ILogger _logger;
         internal readonly ConcurrentQueue<UnacknowledgedRenderBatch> _unacknowledgedRenderBatches = new ConcurrentQueue<UnacknowledgedRenderBatch>();
         private long _nextRenderId = 1;
-        private bool _disposing = false;
+        private bool _disposing;
 
         /// <summary>
         /// Notifies when a rendering exception occurred.

src/Components/WebAssembly/Authentication.Msal/src/Models/MsalAuthenticationOptions.cs

@@ -48,7 +48,7 @@ public class MsalAuthenticationOptions
         /// <summary>
         /// Gets or sets whether or not to navigate to the login request url after a successful login.
         /// </summary>
-        public bool NavigateToLoginRequestUrl { get; set; } = false;
+        public bool NavigateToLoginRequestUrl { get; set; }
 
         /// <summary>
         /// Gets or sets the set of known authority host names for the application.

src/Components/WebAssembly/WebAssembly.Authentication/src/Services/RemoteAuthenticationService.cs

@@ -27,7 +27,7 @@ public class RemoteAuthenticationService<TRemoteAuthenticationState, [Dynamicall
         where TAccount : RemoteUserAccount
     {
         private static readonly TimeSpan _userCacheRefreshInterval = TimeSpan.FromSeconds(60);
-        private bool _initialized = false;
+        private bool _initialized;
 
         // This defaults to 1/1/1970
         private DateTimeOffset _userLastCheck = DateTimeOffset.FromUnixTimeSeconds(0);

src/DataProtection/DataProtection/src/EphemeralDataProtectionProvider.cs

@@ -86,7 +86,7 @@ public EphemeralKeyRing(ILoggerFactory loggerFactory)
 
             public IAuthenticatedEncryptor? DefaultAuthenticatedEncryptor { get; }
 
-            public Guid DefaultKeyId { get; } = default(Guid);
+            public Guid DefaultKeyId { get; }
 
             public IAuthenticatedEncryptor? GetAuthenticatedEncryptorByKeyId(Guid keyId, out bool isRevoked)
             {

src/Features/JsonPatch/src/Internal/ParsedPath.cs

@@ -14,8 +14,6 @@ namespace Microsoft.AspNetCore.JsonPatch.Internal
     /// </summary>
     public readonly struct ParsedPath
     {
-        private static readonly string[] Empty = null;
-
         private readonly string[] _segments;
 
         public ParsedPath(string path)
@@ -41,7 +39,7 @@ public string LastSegment
             }
         }
 
-        public IReadOnlyList<string> Segments => _segments ?? Empty;
+        public IReadOnlyList<string> Segments => _segments;
 
         private static string[] ParsePath(string path)
         {