Enable CA1821, CA1825-CA1834 (dotnet#33041)

* Enable CA1821, CA1825-CA1834

Contributes to dotnet#24055

Author: pranavkm

.editorconfig

@@ -91,9 +91,40 @@ dotnet_diagnostic.CA1802.severity = warning
 # CA1805: Do not initialize unnecessarily
 dotnet_diagnostic.CA1805.severity = warning
 
+# CA1823: Remove empty Finalizers
+dotnet_diagnostic.CA1821.severity = warning
+
 # CA1823: Avoid unused private fields
 dotnet_diagnostic.CA1823.severity = warning
 
+# CA1823: Avoid zero-length array allocations
+dotnet_diagnostic.CA1825.severity = warning
+
+# CA1826: Do not use Enumerable methods on indexable collections. Instead use the collection directly
+dotnet_diagnostic.CA1826.severity = warning
+
+# CA1827: Do not use Count() or LongCount() when Any() can be used
+dotnet_diagnostic.CA1827.severity = warning
+
+# CA1828: Do not use CountAsync() or LongCountAsync() when AnyAsync() can be used
+dotnet_diagnostic.CA1828.severity = warning
+
+# CA1829: Use Length/Count property instead of Count() when available
+dotnet_diagnostic.CA1829.severity = warning
+
+# CA1830: Prefer strongly-typed Append and Insert method overloads on StringBuilder
+dotnet_diagnostic.CA1830.severity = warning
+
+# CA1831: Use AsSpan or AsMemory instead of Range-based indexers when appropriate
+# CA1832: Use AsSpan or AsMemory instead of Range-based indexers when appropriate
+# CA1833: Use AsSpan or AsMemory instead of Range-based indexers when appropriate
+dotnet_diagnostic.CA1831.severity = warning
+dotnet_diagnostic.CA1832.severity = warning
+dotnet_diagnostic.CA1833.severity = warning
+
+# CA1834: Consider using 'StringBuilder.Append(char)' when applicable
+dotnet_diagnostic.CA1834.severity = warning
+
 # CA2012: Use ValueTask correctly
 dotnet_diagnostic.CA2012.severity = warning
 
@@ -110,5 +141,15 @@ dotnet_diagnostic.CA1507.severity = suggestion
 dotnet_diagnostic.CA1802.severity = suggestion
 # CA1805: Do not initialize unnecessarily
 dotnet_diagnostic.CA1805.severity = suggestion
+# CA1823: Avoid zero-length array allocations
+dotnet_diagnostic.CA1825.severity = suggestion
+# CA1826: Do not use Enumerable methods on indexable collections. Instead use the collection directly
+dotnet_diagnostic.CA1826.severity = suggestion
+# CA1827: Do not use Count() or LongCount() when Any() can be used
+dotnet_diagnostic.CA1827.severity = suggestion
+# CA1829: Use Length/Count property instead of Count() when available
+dotnet_diagnostic.CA1829.severity = suggestion
+# CA1834: Consider using 'StringBuilder.Append(char)' when applicable
+dotnet_diagnostic.CA1834.severity = suggestion
 # CA2012: Use ValueTask correctly
 dotnet_diagnostic.CA2012.severity = suggestion

eng/tools/BaselineGenerator/Program.cs

@@ -168,7 +168,7 @@ private async Task<int> Run()
                     foreach (var group in reader.NuspecReader.GetDependencyGroups())
                     {
                         // Don't bother generating empty ItemGroup elements.
-                        if (group.Packages.Count() == 0)
+                        if (!group.Packages.Any())
                         {
                             continue;
                         }

src/Components/Analyzers/test/Verifiers/DiagnosticVerifier.cs

@@ -109,7 +109,7 @@ private void VerifyDiagnostics(string[] sources, string language, DiagnosticAnal
         /// <param name="expectedResults">Diagnostic Results that should have appeared in the code</param>
         private static void VerifyDiagnosticResults(IEnumerable<Diagnostic> actualResults, DiagnosticAnalyzer analyzer, params DiagnosticResult[] expectedResults)
         {
-            int expectedCount = expectedResults.Count();
+            int expectedCount = expectedResults.Length;
             int actualCount = actualResults.Count();
 
             if (expectedCount != actualCount)

src/Components/WebAssembly/WebAssembly/src/Services/WebAssemblyConsoleLogger.cs

@@ -119,9 +119,9 @@ private void CreateDefaultLogMessage(StringBuilder logBuilder, LogLevel logLevel
             logBuilder.Append(GetLogLevelString(logLevel));
             logBuilder.Append(_loglevelPadding);
             logBuilder.Append(logName);
-            logBuilder.Append("[");
+            logBuilder.Append('[');
             logBuilder.Append(eventId);
-            logBuilder.Append("]");
+            logBuilder.Append(']');
 
             if (!string.IsNullOrEmpty(message))
             {

src/Components/WebView/WebView/src/QueryString.cs

@@ -292,9 +292,9 @@ public override int GetHashCode()
 
         private static void AppendKeyValuePair(StringBuilder builder, string key, string? value, bool first)
         {
-            builder.Append(first ? "?" : "&");
+            builder.Append(first ? '?' : '&');
             builder.Append(UrlEncoder.Default.Encode(key));
-            builder.Append("=");
+            builder.Append('=');
             if (!string.IsNullOrEmpty(value))
             {
                 builder.Append(UrlEncoder.Default.Encode(value));

src/FileProviders/Embedded/src/Manifest/ManifestParser.cs

@@ -143,7 +143,7 @@ private static string EnsureName(XElement element)
 
         private static string EnsureText(XElement element)
         {
-            if (element.Elements().Count() == 0 &&
+            if (!element.Elements().Any() &&
                 !element.IsEmpty &&
                 element.Nodes().Count() == 1 &&
                 element.FirstNode?.NodeType == XmlNodeType.Text)

src/Http/Headers/src/CookieHeaderValue.cs

@@ -94,7 +94,7 @@ public override string ToString()
             var header = new StringBuilder();
 
             header.Append(_name.AsSpan());
-            header.Append("=");
+            header.Append('=');
             header.Append(_value.AsSpan());
 
             return header.ToString();

src/Http/Headers/src/SetCookieHeaderValue.cs

@@ -329,7 +329,7 @@ private static void Append(ref Span<char> span, ReadOnlySpan<char> other)
         public void AppendToStringBuilder(StringBuilder builder)
         {
             builder.Append(_name.AsSpan());
-            builder.Append("=");
+            builder.Append('=');
             builder.Append(_value.AsSpan());
 
             if (Expires.HasValue)
@@ -388,7 +388,7 @@ private static void AppendSegment(StringBuilder builder, StringSegment name, Str
             builder.Append(name.AsSpan());
             if (value != null)
             {
-                builder.Append("=");
+                builder.Append('=');
                 builder.Append(value.AsSpan());
             }
         }

src/Http/Http.Abstractions/src/QueryString.cs

@@ -286,9 +286,9 @@ public override int GetHashCode()
 
         private static void AppendKeyValuePair(StringBuilder builder, string key, string? value, bool first)
         {
-            builder.Append(first ? "?" : "&");
+            builder.Append(first ? '?' : '&');
             builder.Append(UrlEncoder.Default.Encode(key));
-            builder.Append("=");
+            builder.Append('=');
             if (!string.IsNullOrEmpty(value))
             {
                 builder.Append(UrlEncoder.Default.Encode(value));

src/Http/Routing/src/DefaultLinkGenerator.cs

@@ -480,14 +480,14 @@ private static string FormatRouteValues(IReadOnlyDictionary<string, object> valu
 
                 foreach (var kvp in values.OrderBy(kvp => kvp.Key))
                 {
-                    builder.Append("\"");
+                    builder.Append('"');
                     builder.Append(kvp.Key);
-                    builder.Append("\"");
-                    builder.Append(":");
-                    builder.Append(" ");
-                    builder.Append("\"");
+                    builder.Append('"');
+                    builder.Append(':');
+                    builder.Append(' ');
+                    builder.Append('"');
                     builder.Append(kvp.Value);
-                    builder.Append("\"");
+                    builder.Append('"');
                     builder.Append(", ");
                 }