apply clippy suggestions.

the `new` method in credential and assertion maybe failed with nullptr, but now always assume alloc not fail

Author: tyan-boot

fido2-rs/src/assertion.rs

@@ -133,6 +133,7 @@ impl_assertion_set!(AssertRequest, 0.ptr);
 
 impl AssertRequest {
     /// Return a [AssertRequest]
+    #[allow(clippy::new_without_default)]
     pub fn new() -> AssertRequest {
         unsafe {
             let assert = ffi::fido_assert_new();
@@ -151,6 +152,7 @@ impl_assertion_set!(AssertVerifier, 0.ptr);
 
 impl AssertVerifier {
     /// Return a [AssertVerifier] for verify.
+    #[allow(clippy::new_without_default)]
     pub fn new() -> AssertVerifier {
         unsafe {
             let assert = ffi::fido_assert_new();
@@ -428,7 +430,7 @@ impl Assertions {
         let count = self.count();
 
         AssertionIter {
-            asserts: &self,
+            asserts: self,
             idx: 0,
             count,
         }

fido2-rs/src/credentials.rs

@@ -18,6 +18,7 @@ impl Drop for Credential {
 
 impl Credential {
     /// Create a new credential
+    #[allow(clippy::new_without_default)]
     pub fn new() -> Self {
         unsafe {
             let cred = ffi::fido_cred_new();

fido2-rs/src/lib.rs

@@ -38,13 +38,11 @@
 //! ```rust,no_run
 //! use fido2_rs::device::DeviceList;
 //!
-//! fn main() {
-//!     let list = DeviceList::list_devices(4);
-//!
-//!     for dev in list {
-//!         println!("{:?}", dev.path);
-//!     }
+//! let list = DeviceList::list_devices(4);
+//! for dev in list {
+//!     println!("{:?}", dev.path);
 //! }
+//!
 //! ```
 //!
 //! ## Make a credential

libfido2-sys/build.rs

@@ -51,7 +51,7 @@ fn main() -> Result<()> {
         return Ok(());
     }
 
-    if let Ok(_) = env::var("FIDO2_USE_PKG_CONFIG") {
+    if env::var("FIDO2_USE_PKG_CONFIG").is_ok() {
         find_pkg()?;
 
         return Ok(());
@@ -92,7 +92,7 @@ fn main() -> Result<()> {
 fn verify_sha256(content: &[u8]) -> bool {
     let sha256 = Sha256::digest(content);
 
-    &*sha256 == hex::decode(SHA256).unwrap()
+    *sha256 == hex::decode(SHA256).unwrap()
 }
 
 /// for windows and msvc, use pre-build