Enable variable tootlip in json request body #4885
Open
+262
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stupidly-logical
requested review from
helloanoop,
maintainer-bruno,
lohit-bruno and
naman-bruno
as code owners
stupidly-logical
changed the title
|
Requesting review @maintainer-bruno |
maintainer-bruno
requested changes
Jun 18, 2025
| @@ -362,7 +367,7 @@ export default class CodeEditor extends React.Component { | |||
| } | |||
|
|
|||
| addOverlay = () => { | |||
| const mode = this.props.mode || 'application/ld+json'; | |||
| const mode = 'text/plain'; | |||
There was a problem hiding this comment.
We should avoid hard-coding the mode here, as it affects syntax highlighting behavior.
After this update
Before this update
There was a problem hiding this comment.
I see the difference. I am looking into it. Do you have ideas?
There was a problem hiding this comment.
@stupidly-logical I've pushed some changes—please have a look when you get a chance.
Just a note: the tooltip for string values was already working. I believe the issue you encountered was due to the {{name}} variable not being enclosed in double quotes.
My update adds support for non-string values like numbers and booleans.
eg:
{
"username": "{{name}}",
"id": {{number}},
"hasValidPassport": {{boolean}}
}
maintainer-bruno
force-pushed
the
feat/enable_req_var_tootlip
branch
from
e6b2eae to
a8db38c
Compare
naman-bruno
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contribution Checklist:
This PR fixes #4884
Sample:
