Skip to content

Commit 1222077

Browse files
author
eugenp
committed
cleanup work
1 parent 33b6d5c commit 1222077

File tree

14 files changed

+123
-119
lines changed

14 files changed

+123
-119
lines changed

spring-security-login-error-handling/src/main/java/org/baeldung/persistence/dao/UserRepository.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import org.springframework.data.jpa.repository.JpaRepository;
44
import org.baeldung.persistence.model.User;
55

6-
7-
public interface UserRepository extends JpaRepository<User,Long>{
6+
public interface UserRepository extends JpaRepository<User, Long> {
87
public User findByUsername(String username);
98
}

spring-security-login-error-handling/src/main/java/org/baeldung/persistence/model/Role.java

Lines changed: 51 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -11,52 +11,58 @@
1111
import javax.persistence.OneToOne;
1212
import javax.persistence.Table;
1313

14-
15-
@Entity(name="role")
14+
@Entity(name = "role")
1615
@Table(name = "role")
1716
public class Role {
1817

19-
@Id
20-
@GeneratedValue(strategy = GenerationType.AUTO)
21-
private Long id;
22-
23-
24-
@OneToOne(targetEntity = User.class, fetch = FetchType.EAGER, cascade = CascadeType.ALL)
25-
@JoinColumn(name = "user_id")
26-
private User user;
27-
28-
@Column(name="role")
29-
private Integer role;
30-
31-
public Role(){
32-
super();
33-
34-
}
35-
public Role(Integer role){
36-
super();
37-
this.role = role;
38-
}
39-
public Role(Integer role, User user){
40-
super();
41-
this.role = role;
42-
this.user = user;
43-
}
44-
public Long getId() {
45-
return id;
46-
}
47-
public void setId(Long id) {
48-
this.id = id;
49-
}
50-
public User getUser() {
51-
return user;
52-
}
53-
public void setUser(User user) {
54-
this.user = user;
55-
}
56-
public Integer getRole() {
57-
return role;
58-
}
59-
public void setRole(Integer role) {
60-
this.role = role;
61-
}
18+
@Id
19+
@GeneratedValue(strategy = GenerationType.AUTO)
20+
private Long id;
21+
22+
@OneToOne(targetEntity = User.class, fetch = FetchType.EAGER, cascade = CascadeType.ALL)
23+
@JoinColumn(name = "user_id")
24+
private User user;
25+
26+
@Column(name = "role")
27+
private Integer role;
28+
29+
public Role() {
30+
super();
31+
32+
}
33+
34+
public Role(Integer role) {
35+
super();
36+
this.role = role;
37+
}
38+
39+
public Role(Integer role, User user) {
40+
super();
41+
this.role = role;
42+
this.user = user;
43+
}
44+
45+
public Long getId() {
46+
return id;
47+
}
48+
49+
public void setId(Long id) {
50+
this.id = id;
51+
}
52+
53+
public User getUser() {
54+
return user;
55+
}
56+
57+
public void setUser(User user) {
58+
this.user = user;
59+
}
60+
61+
public Integer getRole() {
62+
return role;
63+
}
64+
65+
public void setRole(Integer role) {
66+
this.role = role;
67+
}
6268
}

spring-security-login-error-handling/src/main/java/org/baeldung/persistence/model/User.java

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,16 @@ public class User {
1717
@Id
1818
@GeneratedValue(strategy = GenerationType.AUTO)
1919
private Long id;
20-
@Column(name="firstName")
20+
@Column(name = "firstName")
2121
private String firstName;
22-
@Column(name="lastName")
22+
@Column(name = "lastName")
2323
private String lastName;
24-
@Column(name="username")
24+
@Column(name = "username")
2525
private String username;
26-
@Column(name="password")
26+
@Column(name = "password")
2727
private String password;
28-
29-
30-
@OneToOne(mappedBy = "user",fetch = FetchType.EAGER, cascade = CascadeType.ALL)
28+
29+
@OneToOne(mappedBy = "user", fetch = FetchType.EAGER, cascade = CascadeType.ALL)
3130
private Role role;
3231

3332
public Long getId() {
@@ -77,8 +76,7 @@ public Role getRole() {
7776
public void setRole(Role role) {
7877
this.role = role;
7978
}
80-
81-
79+
8280
@Override
8381
public int hashCode() {
8482
final int prime = 31;
@@ -100,11 +98,11 @@ public boolean equals(final Object obj) {
10098
return false;
10199
return true;
102100
}
101+
103102
@Override
104103
public String toString() {
105104
final StringBuilder builder = new StringBuilder();
106-
builder.append("User [firstName=").append(firstName).append("]").
107-
append("[lastName=").append(lastName).append("]").append("[username").append(username).append("]");
105+
builder.append("User [firstName=").append(firstName).append("]").append("[lastName=").append(lastName).append("]").append("[username").append(username).append("]");
108106
return builder.toString();
109107
}
110108
}

spring-security-login-error-handling/src/main/java/org/baeldung/persistence/service/EmailExistsException.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package org.baeldung.persistence.service;
22

33
@SuppressWarnings("serial")
4-
public class EmailExistsException extends Throwable{
5-
4+
public class EmailExistsException extends Throwable {
5+
66
public EmailExistsException(String message) {
77
super(message);
88
}

spring-security-login-error-handling/src/main/java/org/baeldung/persistence/service/RepositoryService.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,33 +10,33 @@
1010

1111
@Service
1212
public class RepositoryService implements UserService {
13-
@Autowired
13+
@Autowired
1414
private UserRepository repository;
15-
15+
1616
@Autowired
1717
private Environment env;
18-
18+
1919
@Autowired
20-
public RepositoryService( UserRepository repository) {
20+
public RepositoryService(UserRepository repository) {
2121
this.repository = repository;
22-
}
23-
22+
}
23+
2424
@Transactional
2525
@Override
2626
public User registerNewUserAccount(UserDto userAccountData) throws EmailExistsException {
2727
if (emailExist(userAccountData.getUsername())) {
28-
28+
2929
throw new EmailExistsException("There is an account with that email adress: " + userAccountData.getUsername());
30-
}
31-
User user = new User();
30+
}
31+
User user = new User();
3232
user.setFirstName(userAccountData.getFirstName());
3333
user.setLastName(userAccountData.getLastName());
3434
user.setPassword(userAccountData.getPassword());
3535
user.setUsername(userAccountData.getUsername());
3636
user.setRole(new Role(userAccountData.getRole(), user));
37-
return repository.save(user);
37+
return repository.save(user);
3838
}
39-
39+
4040
private boolean emailExist(String email) {
4141
User user = repository.findByUsername(email);
4242
if (user != null) {

spring-security-login-error-handling/src/main/java/org/baeldung/persistence/service/UserDto.java

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,43 +5,52 @@ public class UserDto {
55
private String lastName;
66
private String password;
77
private String username;
8-
private Integer role;
9-
8+
private Integer role;
9+
1010
public Integer getRole() {
1111
return role;
1212
}
13+
1314
public void setRole(Integer role) {
1415
this.role = role;
1516
}
17+
1618
public String getUsername() {
1719
return username;
1820
}
21+
1922
public void setUsername(String username) {
2023
this.username = username;
2124
}
25+
2226
public String getFirstName() {
2327
return firstName;
2428
}
29+
2530
public void setFirstName(String firstName) {
2631
this.firstName = firstName;
2732
}
33+
2834
public String getLastName() {
2935
return lastName;
3036
}
37+
3138
public void setLastName(String lastName) {
3239
this.lastName = lastName;
3340
}
41+
3442
public String getPassword() {
3543
return password;
3644
}
45+
3746
public void setPassword(String password) {
3847
this.password = password;
3948
}
49+
4050
@Override
4151
public String toString() {
4252
final StringBuilder builder = new StringBuilder();
43-
builder.append("User [firstName=").append(firstName).append("]").
44-
append("[lastName=").append(lastName).append("]").append("[username").append(username).append("]").append("[password").append(password).append("]");
53+
builder.append("User [firstName=").append(firstName).append("]").append("[lastName=").append(lastName).append("]").append("[username").append(username).append("]").append("[password").append(password).append("]");
4554
return builder.toString();
4655
}
4756
}
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
package org.baeldung.persistence.service;
2+
23
import org.baeldung.persistence.model.User;
34

45
public interface UserService {
5-
6+
67
public User registerNewUserAccount(UserDto userAccountData) throws EmailExistsException;
78

89
}

spring-security-login-error-handling/src/main/java/org/baeldung/persistence/service/UserValidator.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,18 @@ public class UserValidator implements Validator {
1010
private Pattern pattern;
1111
private Matcher matcher;
1212
private static final String EMAIL_PATTERN = "^[_A-Za-z0-9-\\+]+(\\.[_A-Za-z0-9-]+)*@" + "[A-Za-z0-9-]+(\\.[A-Za-z0-9]+)*(\\.[A-Za-z]{2,})$";
13-
13+
1414
@Override
1515
public boolean supports(Class<?> clazz) {
1616
return UserDto.class.isAssignableFrom(clazz);
1717
}
18-
18+
1919
@Override
2020
public void validate(Object obj, Errors errors) {
2121
ValidationUtils.rejectIfEmptyOrWhitespace(errors, "firstName", "message.firstName", "Firstname is required.");
2222
ValidationUtils.rejectIfEmptyOrWhitespace(errors, "lastName", "message.lastName", "LastName is required.");
2323
ValidationUtils.rejectIfEmptyOrWhitespace(errors, "password", "message.password", "LastName is required.");
24-
ValidationUtils.rejectIfEmptyOrWhitespace(errors, "username", "message.username", "UserName is required.");
24+
ValidationUtils.rejectIfEmptyOrWhitespace(errors, "username", "message.username", "UserName is required.");
2525
}
2626

2727
public boolean validateEmail(String email) {

spring-security-login-error-handling/src/main/java/org/baeldung/security/MyUserDetailsService.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,33 +22,33 @@
2222
public class MyUserDetailsService implements UserDetailsService {
2323

2424
private static final Logger LOGGER = LoggerFactory.getLogger(UserDetailsService.class);
25-
25+
2626
private UserRepository userRepository;
2727

2828
@Autowired
2929
public MyUserDetailsService(UserRepository repository) {
3030
this.userRepository = repository;
3131
}
32-
32+
3333
public UserDetails loadUserByUsername(String username) throws UsernameNotFoundException {
3434
try {
3535
LOGGER.debug("Loading user by username: {}", username);
3636
User user = userRepository.findByUsername(username);
3737
LOGGER.debug("Found user: {}", user);
3838
if (user == null) {
39-
//throw new UsernameNotFoundException("No user found with username: " + username);
40-
boolean enabled = false;
41-
return new org.springframework.security.core.userdetails.User(" ", " ", enabled, true, true, true, getAuthorities(new Integer(1)));
39+
// throw new UsernameNotFoundException("No user found with username: " + username);
40+
boolean enabled = false;
41+
return new org.springframework.security.core.userdetails.User(" ", " ", enabled, true, true, true, getAuthorities(new Integer(1)));
4242
}
4343
boolean enabled = true;
4444
boolean accountNonExpired = true;
4545
boolean credentialsNonExpired = true;
4646
boolean accountNonLocked = true;
47-
return new org.springframework.security.core.userdetails.User(user.getUsername(), user.getPassword().toLowerCase(), enabled, accountNonExpired, credentialsNonExpired, accountNonLocked, getAuthorities(user.getRole().getRole()));
47+
return new org.springframework.security.core.userdetails.User(user.getUsername(), user.getPassword().toLowerCase(), enabled, accountNonExpired, credentialsNonExpired, accountNonLocked, getAuthorities(user.getRole().getRole()));
4848

4949
} catch (Exception e) {
5050
throw new RuntimeException(e);
51-
}
51+
}
5252
}
5353

5454
public Collection<? extends GrantedAuthority> getAuthorities(Integer role) {
@@ -60,7 +60,7 @@ public List<String> getRoles(Integer role) {
6060
List<String> roles = new ArrayList<String>();
6161

6262
if (role.intValue() == 2) {
63-
// roles.add("ROLE_USER");
63+
// roles.add("ROLE_USER");
6464
roles.add("ROLE_ADMIN");
6565

6666
} else if (role.intValue() == 1) {
@@ -69,7 +69,7 @@ public List<String> getRoles(Integer role) {
6969

7070
return roles;
7171
}
72-
72+
7373
public static List<GrantedAuthority> getGrantedAuthorities(List<String> roles) {
7474
List<GrantedAuthority> authorities = new ArrayList<GrantedAuthority>();
7575
for (String role : roles) {

spring-security-login-error-handling/src/main/java/org/baeldung/spring/AppConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
@Import({ MvcConfig.class, PersistenceJPAConfig.class, SecSecurityConfig.class })
1313
@PropertySource("classpath:application.properties")
1414
public class AppConfig {
15-
15+
1616
@Bean
1717
public static PropertySourcesPlaceholderConfigurer propertyPlaceHolderConfigurer() {
1818
return new PropertySourcesPlaceholderConfigurer();

0 commit comments

Comments
 (0)