-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Labels
feature requestNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
🚀 The feature, motivation and pitch
Currently, in the Attention
layer, we check if process_weights_after_loading
exists and then call it conditionally, and after that we apply flashinfer-specific logic.
Instead, we should just add a process_weights_after_loading
method to AttentionImpl (no-op) by default, call it from Attention.process_weights_after_loading
, and override it in FlashInferAttentionImpl
.
Alternatives
No response
Additional context
Before submitting a new issue...
- Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
Metadata
Metadata
Assignees
Labels
feature requestNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed