Add way how to force real redirect

[voslartomas]

Hi, what is the purpose of assigning redirect value to this.href? I've used old redirect function from nette.ajax and after session is expired, it was redirecting to login page. Now after implementation of history.nette.ajax, there is a problem, because it is not redirecting because of this condition.

if (redirect) {
        var regexp = new RegExp('//' + window.location.host + '($|/)');
        if ((redirect.substring(0,4) === 'http') ? regexp.test(redirect) : true) {
            this.href = redirect;
        } else {
            window.location.href = redirect;
        }
    }

[vojtech-dobes]

This code's purpose is to ensure, that if you make redirectUrl on serverside, you will be actually redirected there (in ajax, Nette will return the external URL in payload as usual). If it's not external URL, it's passed to this.href, so it can be processed by History API.

You don't want hard redirect after ajax request - otherwise rather screw the ajax and use normal request, as that's far more understandable behavior to users.

[voslartomas]

Okay, got it, but if you are redirecting, it just pass this URL, without any content in payload, so it just nicely change URL, but nothing else happen. Is that really good behaviour? Guess I am missing something.

[vojtech-dobes]

Well, if you don't want to change URL, why would you redirect in the first place :) ?

[voslartomas]

I want change the URL, but I want to change the content as well :) But there is no information about content if I call $this->redirect(''); from controller. So it just change the URL, but I need the content to be changed as well.

[vojtech-dobes]

History extension for nette.ajax.js should work like this: assume example scenario of form being submitted, and after that you are redirected to overview page. So, normally you would make redirect to overview page. With ajax, you can update snippets, but only on the page with forms. But with HistoryExtension, you can make redirect as usual, but in ajax request, the redirect will be immediately executed, and ideally you should invalidate (redraw) some main content snippet - so submitting form returns you URL of overview, and snippet with the whole overview page content. Which is handled automatically by snippets extension.

[voslartomas]

No doubt about that, I think you misunderstand what I am trying to say. I don't want to remove this behaviour, but I have this trouble with loging out, when I am using redirect function. So maybe there should be one more condition for this or I missing something and there is another way to change content. Or do you have something in payload (except url address to redirect), if you are redirecting on the very beginning of the controller process? I am sorry, I don't want to contest your work at all. I like it, but I don't know what to do in this concrete situation:)

[vojtech-dobes]

Yes, each redirect should end with something in snippets field of payload :). Each redirect is processed on serverside immediately (like using forward() method). So the page where you get after logging out shculd (in ajax mode) send proper content, that can be processed on client side.

[voslartomas]

Ok, one more scenario, what if you want redirect to different layout page? That means, you need refresh whole page? This should be done via window.location.href right? So maybe, there should be some payload parameter, like refresh, which will do this, shouldn't be?

[vojtech-dobes]

Well, I rather think such action should not be ajaxified.

[voslartomas]

That is hard to do :) If you have to check (again my example, sorry for that), whether is user logged in or not in every request (even in that ajax requests).

[vojtech-dobes]

Sorry, I didn't pay appropriate attention to your initial example, I apologize. You're right, that's difficult scenario. In such case it makes sense to make hard redirect even as result of ajax request.

I like clean API, maybe that's just my obsession, but what about following approach:

Your problem is only with some let's say LoginPresenter. That one requires hard redirect to. So you could mark it with annotation @noAjaxForward, and then the internal forward would be omitted, application would put redirectForce to payload instead of redirect, and that would be always processed as hard redirect. This is possible to implement for Nette 2.1.1 I think. How do you like such idea?

[voslartomas]

Believe or not I like clean API as well, your approach is very nice, but I am still using Nette version 2.0.* so I guess it is not possible, but it doesn't matter I can do another workaround for this situation, I was just curious, if we can implement this additional staff into this library (it would be more clear from my point of view), but I can see your point of view as well :) So thank you very much for your time!

[vojtech-dobes]

Hm, there is http://api.nette.org/2.1.2/source-Application.UI.Presenter.php.html#701-708, so maybe it could be implemented for 2.0.0 as well, in ResponseHandler instead of onPresenter (which was added in 2.1.1).

And of course, it still requires change in JS, support for that redirectForce or something. So I guess you can base your workaround by simple utilizing such field in payload. I will try to implement it as soon as possible, because this is good usecase - probably during the week. Thanks for dragging me to thinking about this :).

[voslartomas]

Thanks for suggestions :) I will try do some workaround for now and I will wait for your implementation...