Skip to content

Commit b0e44a2

Browse files
committed
Fix term counters in script field terms facet
Fixes elastic#2878
1 parent ae74a8d commit b0e44a2

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/main/java/org/elasticsearch/search/facet/terms/strings/ScriptTermsStringFieldFacetExecutor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ public void collect(int doc) throws IOException {
182182
@Override
183183
public void postCollection() {
184184
ScriptTermsStringFieldFacetExecutor.this.missing = missing;
185-
ScriptTermsStringFieldFacetExecutor.this.total = missing;
185+
ScriptTermsStringFieldFacetExecutor.this.total = total;
186186
}
187187

188188
private boolean match(String value) {

src/test/java/org/elasticsearch/test/integration/search/facet/SimpleFacetsTests.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1297,11 +1297,15 @@ private void testTermsFacets(String executionHint) throws Exception {
12971297

12981298
facet = searchResponse.getFacets().facet("facet1");
12991299
assertThat(facet.getName(), equalTo("facet1"));
1300+
assertThat(facet.getTotalCount(), equalTo(2l));
1301+
assertThat(facet.getOtherCount(), equalTo(0l));
13001302
assertThat(facet.getEntries().size(), equalTo(1));
13011303
assertThat(facet.getEntries().get(0).getTerm().string(), equalTo("111"));
13021304
assertThat(facet.getEntries().get(0).getCount(), equalTo(2));
13031305

13041306
facet = searchResponse.getFacets().facet("facet2");
1307+
assertThat(facet.getTotalCount(), equalTo(4l));
1308+
assertThat(facet.getOtherCount(), equalTo(0l));
13051309
assertThat(facet.getName(), equalTo("facet2"));
13061310
assertThat(facet.getEntries().size(), equalTo(3));
13071311
assertThat(facet.getEntries().get(0).getTerm().string(), equalTo("yyy"));

0 commit comments

Comments
 (0)