Skip to content

Commit c0ca7e4

Browse files
authored
fix: Specifies timeout in exception polling (feast-dev#3398)
* Specifies timeout in exception polling Signed-off-by: gbmarc1 <[email protected]> * Update bigquery.py Signed-off-by: gbmarc1 <[email protected]> Signed-off-by: gbmarc1 <[email protected]>
1 parent 963bd88 commit c0ca7e4

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

sdk/python/feast/infra/offline_stores/bigquery.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -608,8 +608,11 @@ def _wait_until_done(bq_job):
608608
client.cancel_job(bq_job.job_id)
609609
raise BigQueryJobCancelled(job_id=bq_job.job_id)
610610

611-
if bq_job.exception():
612-
raise bq_job.exception()
611+
# We explicitly set the timeout to None because `google-api-core` changed the default value and
612+
# breaks downstream libraries.
613+
# https://github.com/googleapis/python-api-core/issues/479
614+
if bq_job.exception(timeout=None):
615+
raise bq_job.exception(timeout=None)
613616

614617

615618
def _get_table_reference_for_new_entity(

0 commit comments

Comments
 (0)