Skip to content

Commit 0297f67

Browse files
authored
Merge pull request systemd#9036 from keszybz/rpm-macro-cleanup
rpm macro cleanup
2 parents 6982156 + 424e80b commit 0297f67

File tree

2 files changed

+20
-15
lines changed

2 files changed

+20
-15
lines changed

meson.build

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -241,12 +241,14 @@ substs.set('userpresetdir', userpresetdir)
241241
substs.set('udevhwdbdir', udevhwdbdir)
242242
substs.set('udevrulesdir', udevrulesdir)
243243
substs.set('udevlibexecdir', udevlibexecdir)
244+
substs.set('environmentdir', environmentdir)
244245
substs.set('catalogdir', catalogdir)
245246
substs.set('tmpfilesdir', tmpfilesdir)
246247
substs.set('sysusersdir', sysusersdir)
247248
substs.set('sysctldir', sysctldir)
248249
substs.set('binfmtdir', binfmtdir)
249250
substs.set('modulesloaddir', modulesloaddir)
251+
substs.set('modprobedir', modprobedir)
250252
substs.set('systemgeneratordir', systemgeneratordir)
251253
substs.set('usergeneratordir', usergeneratordir)
252254
substs.set('systemenvgeneratordir', systemenvgeneratordir)

src/core/macros.systemd.in

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,13 @@
1414
%_udevhwdbdir @udevhwdbdir@
1515
%_udevrulesdir @udevrulesdir@
1616
%_journalcatalogdir @catalogdir@
17-
%_tmpfilesdir @tmpfilesdir@
18-
%_sysusersdir @sysusersdir@
19-
%_sysctldir @sysctldir@
2017
%_binfmtdir @binfmtdir@
18+
%_sysctldir @sysctldir@
19+
%_sysusersdir @sysusersdir@
20+
%_tmpfilesdir @tmpfilesdir@
21+
%_environmnentdir @environmentdir@
22+
%_modulesloaddir @modulesloaddir@
23+
%_modprobedir @modprobedir@
2124
%_systemdgeneratordir @systemgeneratordir@
2225
%_systemdusergeneratordir @usergeneratordir@
2326
%_systemd_system_env_generator_dir @systemenvgeneratordir@
@@ -38,23 +41,23 @@ OrderWithRequires(postun): systemd \
3841
%systemd_post() \
3942
if [ $1 -eq 1 ] ; then \
4043
# Initial installation \
41-
systemctl --no-reload preset %{?*} >/dev/null 2>&1 || : \
44+
systemctl --no-reload preset %{?*} &>/dev/null || : \
4245
fi \
4346
%{nil}
4447

45-
%systemd_user_post() %{expand:%systemd_post \\--user \\--global %%{?*}}
48+
%systemd_user_post() %{expand:%systemd_post \\--global %%{?*}}
4649

4750
%systemd_preun() \
4851
if [ $1 -eq 0 ] ; then \
4952
# Package removal, not upgrade \
50-
systemctl --no-reload disable --now %{?*} > /dev/null 2>&1 || : \
53+
systemctl --no-reload disable --now %{?*} &>/dev/null || : \
5154
fi \
5255
%{nil}
5356

5457
%systemd_user_preun() \
5558
if [ $1 -eq 0 ] ; then \
5659
# Package removal, not upgrade \
57-
systemctl --no-reload --user --global disable %{?*} > /dev/null 2>&1 || : \
60+
systemctl --global disable %{?*} &>/dev/null || : \
5861
fi \
5962
%{nil}
6063

@@ -65,7 +68,7 @@ fi \
6568
%systemd_postun_with_restart() \
6669
if [ $1 -ge 1 ] ; then \
6770
# Package upgrade, not uninstall \
68-
systemctl try-restart %{?*} >/dev/null 2>&1 || : \
71+
systemctl try-restart %{?*} &>/dev/null || : \
6972
fi \
7073
%{nil}
7174

@@ -79,16 +82,16 @@ fi \
7982

8083
# Deprecated. Use %tmpfiles_create_package instead
8184
%tmpfiles_create() \
82-
systemd-tmpfiles --create %{?*} >/dev/null 2>&1 || : \
85+
systemd-tmpfiles --create %{?*} &>/dev/null || : \
8386
%{nil}
8487

8588
# Deprecated. Use %sysusers_create_package instead
8689
%sysusers_create() \
87-
systemd-sysusers %{?*} >/dev/null 2>&1 || : \
90+
systemd-sysusers %{?*} &>/dev/null || : \
8891
%{nil}
8992

9093
%sysusers_create_inline() \
91-
systemd-sysusers - <<SYSTEMD_INLINE_EOF >/dev/null 2>&1 || : \
94+
systemd-sysusers - <<SYSTEMD_INLINE_EOF &>/dev/null || : \
9295
%{?*} \
9396
SYSTEMD_INLINE_EOF \
9497
%{nil}
@@ -107,7 +110,7 @@ SYSTEMD_INLINE_EOF \
107110
# %files
108111
# %{_sysusersdir}/%{name}.conf
109112
%sysusers_create_package() \
110-
systemd-sysusers --replace=%_sysusersdir/%1.conf - <<SYSTEMD_INLINE_EOF >/dev/null 2>&1 || : \
113+
systemd-sysusers --replace=%_sysusersdir/%1.conf - <<SYSTEMD_INLINE_EOF &>/dev/null || : \
111114
%(cat %2) \
112115
SYSTEMD_INLINE_EOF \
113116
%{nil}
@@ -126,15 +129,15 @@ SYSTEMD_INLINE_EOF \
126129
# %files
127130
# %{_tmpfilesdir}/%{name}.conf
128131
%tmpfiles_create_package() \
129-
systemd-tmpfiles --replace=%_tmpfilesdir/%1.conf --create - <<SYSTEMD_INLINE_EOF >/dev/null 2>&1 || : \
132+
systemd-tmpfiles --replace=%_tmpfilesdir/%1.conf --create - <<SYSTEMD_INLINE_EOF &>/dev/null || : \
130133
%(cat %2) \
131134
SYSTEMD_INLINE_EOF \
132135
%{nil}
133136

134137
%sysctl_apply() \
135-
@rootlibexecdir@/systemd-sysctl %{?*} >/dev/null 2>&1 || : \
138+
@rootlibexecdir@/systemd-sysctl %{?*} &>/dev/null || : \
136139
%{nil}
137140

138141
%binfmt_apply() \
139-
@rootlibexecdir@/systemd-binfmt %{?*} >/dev/null 2>&1 || : \
142+
@rootlibexecdir@/systemd-binfmt %{?*} &>/dev/null || : \
140143
%{nil}

0 commit comments

Comments
 (0)