fixed break condition for failed requests

JanMalte · JanMalte · commit 78acdebca2c3 · 2014-05-13T09:45:32.000+02:00
diff --git a/lib/Redmine/Api/AbstractApi.php b/lib/Redmine/Api/AbstractApi.php
@@ -123,7 +123,11 @@ protected function retrieveAll($endpoint, array $params = array())
             $offset += $_limit;
             // Break if the data set is the last one, as the offset is greater
             // than the total count
-            if ($newDataSet['offset'] >= $newDataSet['total_count']) {
+            if (empty($newDataSet)
+                || (array_key_exists('offset', $newDataSet)
+                && array_key_exists('total_count', $newDataSet)
+                && $newDataSet['offset'] >= $newDataSet['total_count'])
+            ) {
                 $limit = 0;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,11 @@ protected function retrieveAll($endpoint, array $params = array())`
`123`	`123`	`$offset += $_limit;`
`124`	`124`	`// Break if the data set is the last one, as the offset is greater`
`125`	`125`	`// than the total count`
`126`		`- if ($newDataSet['offset'] >= $newDataSet['total_count']) {`
	`126`	`+ if (empty($newDataSet)`
	`127`	`+ \|\| (array_key_exists('offset', $newDataSet)`
	`128`	`+ && array_key_exists('total_count', $newDataSet)`
	`129`	`+ && $newDataSet['offset'] >= $newDataSet['total_count'])`
	`130`	`+ ) {`
`127`	`131`	`$limit = 0;`
`128`	`132`	`}`
`129`	`133`	`}`