cleaning

Author: kbsali

.scrutinizer.yml

@@ -164,7 +164,7 @@ coding_style:
                 multiplicative: true
                 shift: true
                 unary_additive: false
-                concatenation: true
+                concatenation: false
                 negation: false
             before_left_brace:
                 class: true

lib/Redmine/Api/AbstractApi.php

@@ -181,7 +181,7 @@ protected function attachCustomFieldXML(SimpleXMLElement $xml, array $fields)
                 $_values = $_field->addChild('value');
                 $_values->addAttribute('type', 'array');
                 foreach ($field['value'] as $val) {
-                    $_value = $_values->addChild('value', $val);
+                    $_values->addChild('value', $val);
                 }
             } else {
                 $_field->addChild('value', $field['value']);

lib/Redmine/Api/Project.php

@@ -136,21 +136,18 @@ public function update($id, array $params)
      */
     protected function prepareParamsXml($params)
     {
-        $array_params = array(
-            'tracker_ids', 'issue_custom_field_ids',
-        );
-        $array_params_elements = array(
+        $_params = array(
             'tracker_ids' => 'tracker',
             'issue_custom_field_ids' => 'issue_custom_field',
         );
 
         $xml = new SimpleXMLElement('<?xml version="1.0"?><project></project>');
         foreach ($params as $k => $v) {
-            if (in_array($k, $array_params) && is_array($v)) {
+            if (isset($_params[$k]) && is_array($v)) {
                 $array = $xml->addChild($k, '');
                 $array->addAttribute('type', 'array');
                 foreach ($v as $id) {
-                    $array->addChild($array_params_elements[$k], $id);
+                    $array->addChild($_params[$k], $id);
                 }
             } else {
                 $xml->addChild($k, $v);

lib/Redmine/Client.php

@@ -321,9 +321,7 @@ public function getImpersonateUser()
      * @param string $path
      * @param string $method
      * @param string $data
-     *
      * @return boolean|SimpleXMLElement|string
-     *
      * @throws \Exception If anything goes wrong on curl request
      */
     protected function runRequest($path, $method = 'GET', $data = '')
@@ -394,7 +392,6 @@ protected function runRequest($path, $method = 'GET', $data = '')
             default: // GET
                 break;
         }
-        /* @var $response boolean|string */
         $response = trim(curl_exec($curl));
         $this->responseCode = curl_getinfo($curl, CURLINFO_HTTP_CODE);
         $contentType = curl_getinfo($curl, CURLINFO_CONTENT_TYPE);