SERVER-22947 fix pessimizing move in batch_executor

milkie · milkie · commit f019f88f0500 · 2016-03-04T10:40:21.000-05:00
diff --git a/src/mongo/db/commands/write_commands/batch_executor.cpp b/src/mongo/db/commands/write_commands/batch_executor.cpp
@@ -341,7 +341,7 @@ void WriteBatchExecutor::executeBatch(const BatchedCommandRequest& request,
                             _txn->getWriteConcern(),
                             &res);
     if (!status.isOK()) {
-        wcError = std::move(toWriteConcernError(status, res));
+        wcError = toWriteConcernError(status, res);
     }
 
     //

Original file line number	Diff line number	Diff line change
`@@ -341,7 +341,7 @@ void WriteBatchExecutor::executeBatch(const BatchedCommandRequest& request,`
`341`	`341`	`_txn->getWriteConcern(),`
`342`	`342`	`&res);`
`343`	`343`	`if (!status.isOK()) {`
`344`		`- wcError = std::move(toWriteConcernError(status, res));`
	`344`	`+ wcError = toWriteConcernError(status, res);`
`345`	`345`	`}`
`346`	`346`
`347`	`347`	`//`