Bug#19459193 GET RID OF DYNAMIC_ARRAY IN CIRCULAR_BUFFER_QUEUE

Post-push fix: -Werror build broken in optimized mode

gcc 4.4 was warning: error: 'group.st_slave_job_group::ts'
solution: use value-initialization of two stack-allocated objects of type Slave_job_group

gcc 4.7 gives warning warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
solution: annotate it with __attribute__((unused))

Author: Tor Didriksen

sql/log_event.cc

@@ -2969,7 +2969,7 @@ bool schedule_next_event(Log_event* ev, Relay_log_info* rli)
 
 Slave_worker *Log_event::get_slave_worker(Relay_log_info *rli)
 {
-  Slave_job_group group, *ptr_group= NULL;
+  Slave_job_group group= Slave_job_group(), *ptr_group= NULL;
   bool is_s_event;
   Slave_worker *ret_worker= NULL;
   char llbuff[22];

sql/rpl_rli_pdb.cc

@@ -1342,7 +1342,7 @@ ulong Slave_committed_queue::move_queue_head(Slave_worker_array *ws)
   for (i= entry; i != avail && !empty(); cnt++, i= (i + 1) % size)
   {
     Slave_worker *w_i;
-    Slave_job_group *ptr_g, g;
+    Slave_job_group *ptr_g;
     char grl_name[FN_REFLEN];
 
 #ifndef DBUG_OFF
@@ -1382,6 +1382,7 @@ ulong Slave_committed_queue::move_queue_head(Slave_worker_array *ws)
     /*
       Removes the job from the (G)lobal (A)ssigned (Q)ueue.
     */
+    Slave_job_group g= Slave_job_group();
 #ifndef DBUG_OFF
     ulong ind=
 #endif

storage/innobase/ut/ut0new.cc

@@ -171,6 +171,7 @@ ut_new_boot()
 	for (size_t i = 0; i < n_auto; i++) {
 
 		const std::pair<mem_keys_auto_t::iterator, bool>	ret
+			__attribute__((unused))
 			= mem_keys_auto.insert(
 			mem_keys_auto_t::value_type(auto_event_names[i],
 						    &auto_event_keys[i]));