Merge pull request operator-framework#506 from gallettilance/db-lock-fix

openshift-merge-robot · web-flow · commit e12d03916f8f · 2020-11-03T19:57:06.000-05:00
Bug 1894278: (fix) close connection to db
diff --git a/pkg/sqlite/query.go b/pkg/sqlite/query.go
@@ -1151,6 +1151,8 @@ func (s *SQLQuerier) GetBundlePathIfExists(ctx context.Context, bundleName strin
 	if err != nil {
 		return
 	}
+	defer rows.Close()
+
 	if !rows.Next() {
 		// no bundlepath set
 		err = registry.ErrBundleImageNotInDatabase

Original file line number	Diff line number	Diff line change
`@@ -1151,6 +1151,8 @@ func (s *SQLQuerier) GetBundlePathIfExists(ctx context.Context, bundleName strin`
`1151`	`1151`	`if err != nil {`
`1152`	`1152`	`return`
`1153`	`1153`	`}`
	`1154`	`+ defer rows.Close()`
	`1155`	`+`
`1154`	`1156`	`if !rows.Next() {`
`1155`	`1157`	`// no bundlepath set`
`1156`	`1158`	`err = registry.ErrBundleImageNotInDatabase`